jiacai2050 commented on code in PR #1599: URL: https://github.com/apache/horaedb/pull/1599#discussion_r1855708228
########## horaedb/metric_engine/src/sst.rs: ########## @@ -31,7 +31,7 @@ pub const PREFIX_PATH: &str = "data"; pub type FileId = u64; -#[derive(Clone, Debug)] +#[derive(Clone, Debug, PartialEq)] Review Comment: `PartialEq`, `Eq` are usually implemented at the same time if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
