imbajin commented on code in PR #352:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/352#discussion_r1009179000


##########
.github/workflows/client-ci.yml:
##########
@@ -46,6 +46,11 @@ jobs:
         with:
           fetch-depth: 2
 
+      - name: License check(RAT)
+        run: |
+          mvn apache-rat:check | grep -v "Downloading\|Downloaded\|Progress"
+          find ./ -name rat.txt -print0 | xargs -0 -I file cat file > 
merged-rat.txt && cat merged-rat.txt
+

Review Comment:
   > I think we'd better throw the exception instead of printing it
   
   any suggestion? it's hard to define `error` now (or any reference from other 
apache repo?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to