[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #336: add third-party dependencies check

[GitBox]

javeme commented on code in PR #336:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/336#discussion_r1011921510


##########
.github/workflows/check-dependencies.yml:
##########
@@ -9,30 +9,21 @@ jobs:
       STATIC_DIR: hugegraph-loader/assembly/static
     steps:
       - name: Checkout source
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Set up JDK 8
-        uses: actions/setup-java@v2
+        uses: actions/setup-java@v3
         with:
           java-version: '8'
           distribution: 'adopt'
       - name: mvn install
-        run:
+        run: |
           mvn install:install-file -Dfile=$STATIC_DIR/lib/ojdbc8-12.2.0.1.jar 
-DgroupId=com.oracle -DartifactId=ojdbc8 -Dversion=12.2.0.1 -Dpackaging=jar
-          mvn install -pl hugegraph-client -am -DskipTests=true
-      - name: mvn dependency:copy-dependencies
-        run:
-          mvn dependency:copy-dependencies -DincludeScope=runtime 
-DoutputDirectory=${{ github.workspace }}/current_dependencies
-      - name: generate current_dependencies.txt
+          mvn install -DskipTests=true
+      - name: generate current dependencies
         run: |
-          ls ${{ github.workspace }}/current_dependencies  |egrep -v 
"^hugegraph" |sort > ~/current_dependencies.txt
-          cat ~/current_dependencies.txt
+          mvn dependency:copy-dependencies -DincludeScope=runtime 
-DoutputDirectory=${{ github.workspace }}/current_dependencies
+          ls ${{ github.workspace }}/current_dependencies  |egrep -v 
"^hugegraph|hubble" |sort > ${{ github.workspace 
}}/tool/dependencies/current-dependencies.txt

Review Comment:
   `current_dependencies  |egrep` => `current_dependencies | egrep`



##########
tool/dependencies/check_dependencies.sh:
##########
@@ -0,0 +1,32 @@
+#!/usr/bin/env bash

Review Comment:
   can we move to `hugegraph-dist/scripts/dependency`



##########
.github/workflows/check-dependencies.yml:
##########
@@ -9,30 +9,21 @@ jobs:
       STATIC_DIR: hugegraph-loader/assembly/static
     steps:
       - name: Checkout source
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Set up JDK 8
-        uses: actions/setup-java@v2
+        uses: actions/setup-java@v3
         with:
           java-version: '8'
           distribution: 'adopt'
       - name: mvn install
-        run:
+        run: |
           mvn install:install-file -Dfile=$STATIC_DIR/lib/ojdbc8-12.2.0.1.jar 
-DgroupId=com.oracle -DartifactId=ojdbc8 -Dversion=12.2.0.1 -Dpackaging=jar
-          mvn install -pl hugegraph-client -am -DskipTests=true
-      - name: mvn dependency:copy-dependencies
-        run:
-          mvn dependency:copy-dependencies -DincludeScope=runtime 
-DoutputDirectory=${{ github.workspace }}/current_dependencies
-      - name: generate current_dependencies.txt
+          mvn install -DskipTests=true
+      - name: generate current dependencies
         run: |
-          ls ${{ github.workspace }}/current_dependencies  |egrep -v 
"^hugegraph" |sort > ~/current_dependencies.txt
-          cat ~/current_dependencies.txt
+          mvn dependency:copy-dependencies -DincludeScope=runtime 
-DoutputDirectory=${{ github.workspace }}/current_dependencies
+          ls ${{ github.workspace }}/current_dependencies  |egrep -v 
"^hugegraph|hubble" |sort > ${{ github.workspace 
}}/tool/dependencies/current-dependencies.txt
+          cat ${{ github.workspace 
}}/tool/dependencies/current-dependencies.txt

Review Comment:
   can also move into `generate_current_dependencies.sh`



##########
.github/workflows/check-dependencies.yml:
##########
@@ -9,30 +9,21 @@ jobs:
       STATIC_DIR: hugegraph-loader/assembly/static
     steps:
       - name: Checkout source
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Set up JDK 8
-        uses: actions/setup-java@v2
+        uses: actions/setup-java@v3
         with:
           java-version: '8'
           distribution: 'adopt'
       - name: mvn install
-        run:
+        run: |
           mvn install:install-file -Dfile=$STATIC_DIR/lib/ojdbc8-12.2.0.1.jar 
-DgroupId=com.oracle -DartifactId=ojdbc8 -Dversion=12.2.0.1 -Dpackaging=jar
-          mvn install -pl hugegraph-client -am -DskipTests=true
-      - name: mvn dependency:copy-dependencies
-        run:
-          mvn dependency:copy-dependencies -DincludeScope=runtime 
-DoutputDirectory=${{ github.workspace }}/current_dependencies
-      - name: generate current_dependencies.txt
+          mvn install -DskipTests=true
+      - name: generate current dependencies
         run: |
-          ls ${{ github.workspace }}/current_dependencies  |egrep -v 
"^hugegraph" |sort > ~/current_dependencies.txt
-          cat ~/current_dependencies.txt
+          mvn dependency:copy-dependencies -DincludeScope=runtime 
-DoutputDirectory=${{ github.workspace }}/current_dependencies

Review Comment:
   can define a env var for the output file path



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org