[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #352: feat(apache): support check license header with RAT client model

Thu, 03 Nov 2022 08:02:06 -0700 


imbajin commented on code in PR #352:
URL: 
https://github.com/apache/incubator-hugegraph-toolchain/pull/352#discussion_r1013025778


##########
.github/workflows/client-ci.yml:
##########
@@ -46,6 +46,11 @@ jobs:
         with:
           fetch-depth: 2
 
+      - name: License check(RAT)
+        run: |
+          mvn apache-rat:check | grep -v "Downloading\|Downloaded\|Progress"
+          find ./ -name rat.txt -print0 | xargs -0 -I file cat file > 
merged-rat.txt && cat merged-rat.txt
+

Review Comment:
   > > I think we'd better throw the exception instead of printing it
   > > do you mean like this?
   > > 
![image](https://user-images.githubusercontent.com/13795366/199660925-11fa5ccb-8274-4cbe-9d39-c8debee3f231.png)
   
   yes, alert all errors is better. like add a a maven param (to not stop it)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to