Re: [PR] refactor: remove 'incubating' branding, update docs & packaging [hugegraph-toolchain]

[via GitHub]

contrueCT commented on PR #716:
URL: 
https://github.com/apache/hugegraph-toolchain/pull/716#issuecomment-4089501872

   > <img alt="image" width="1170" height="441" 
src="https://private-user-images.githubusercontent.com/17706099/566085938-b30b9efc-d4ca-489c-9daa-e82fd70c7494.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzM5MjAyMTcsIm5iZiI6MTc3MzkxOTkxNywicGF0aCI6Ii8xNzcwNjA5OS81NjYwODU5MzgtYjMwYjllZmMtZDRjYS00ODljLTlkYWEtZTgyZmQ3MGM3NDk0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAzMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMzE5VDExMzE1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU4YzI4NDQ4N2VmNThmYTIxYTIyZTZjM2JlNDAyYmEyOGFmMTBhZTAxZGQ3ZjEwNWU5NDEzYThjYjVjNTlkMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.YXl6Zrn7_-_3NaZmYjP_13rqfq4TUTRQ7H7bv0hilOM";>
   > Record the `loader-ci` error & rerun
   
   I checked the failing test case 
`FileLoadTest.testSourceOrTargetPrimaryValueNull()`. From the current code 
path, this looks more like a flaky test issue than a regression caused by this 
PR.
   
   This PR only updates branding-related docs/metadata/package names/paths and 
does not change `hugegraph-loader` runtime logic.
   
   For this test specifically, `loader.load()` is expected to throw, but 
`loader.shutdown()` is placed after it in the same lambda. So once `load()` 
fails, `shutdown()` is not executed, while vertex inserts are still submitted 
asynchronously. The test then immediately queries the graph and assumes all 7 
vertices have already been flushed, which is not guaranteed. That would explain 
the observed `expected:<7> but was:<5>`.
   
   I’ll take another look at whether we should stabilize this test separately, 
but at the moment this failure does not appear to be directly introduced by the 
incubating-branding cleanup in this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org