This is an automated email from the ASF dual-hosted git repository.
dweeks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/master by this push:
new 5f74b33494 Open-api: RenameTableRequest props are required (#5093)
5f74b33494 is described below
commit 5f74b3349486b76859a1faf8fb4960c473f0d591
Author: Fokko Driesprong <[email protected]>
AuthorDate: Mon Jun 20 17:33:05 2022 +0200
Open-api: RenameTableRequest props are required (#5093)
Currently, the properties are optional, which doesn't really make sense.
Also, in the Java code it throws an exception:
https://github.com/apache/iceberg/blob/master/core/src/test/java/org/apache/iceberg/rest/requests/TestRenameTableRequest.java#L106-L121
Therefore I would suggest making those required in the spec as well
---
open-api/rest-catalog-open-api.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/open-api/rest-catalog-open-api.yaml
b/open-api/rest-catalog-open-api.yaml
index 040bc5387e..7e87be0527 100644
--- a/open-api/rest-catalog-open-api.yaml
+++ b/open-api/rest-catalog-open-api.yaml
@@ -869,6 +869,9 @@ components:
RenameTableRequest:
type: object
+ required:
+ - source
+ - destination
properties:
source:
$ref: '#/components/schemas/TableIdentifier'
