This is an automated email from the ASF dual-hosted git repository. blue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/iceberg.git
commit 99b41eb9fbae1eb6c0501ce1fd1c9008893583b4 Author: Eduard Tudenhoefner <[email protected]> AuthorDate: Wed Jul 20 09:30:40 2022 +0200 Build: Use google-java-format 1.7 for JDK8 compatibility Given that CI runs builds with JDK 8 & 11, the google-java-format will actually pick different google-java-format versions depending on the JDK being used (JDK8=google-java-format 1.7 / JDK11=google-java-format latest). Those different google-java-format version are actually producing different formatting results, thus we have to use google-java-format 1.7 here to make things consistent across JDK versions. --- baseline.gradle | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/baseline.gradle b/baseline.gradle index d76f36199..49b936fb5 100644 --- a/baseline.gradle +++ b/baseline.gradle @@ -44,11 +44,10 @@ subprojects { pluginManager.withPlugin('com.diffplug.spotless') { spotless { - // don't run spotlessCheck during gradle check task - enforceCheck = false java { target 'src/main/java/**/*.java', 'src/test/java/**/*.java', 'src/jmh/java/**/*.java' - googleJavaFormat() + // we use an older version of google-java-format that is compatible with JDK 8 + googleJavaFormat("1.7") removeUnusedImports() licenseHeaderFile "$rootDir/.baseline/copyright/copyright-header-java.txt" }
