(iceberg) branch main updated: API, Core: Fix errorprone warnings (#9419)

[fokko]

This is an automated email from the ASF dual-hosted git repository.

fokko pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/main by this push:
     new c6a772618d API, Core: Fix errorprone warnings (#9419)
c6a772618d is described below

commit c6a772618d91f20820015cd7ec5cf6cdea454acd
Author: Ajantha Bhat <ajanthab...@gmail.com>
AuthorDate: Wed Jan 10 19:35:03 2024 +0530

    API, Core: Fix errorprone warnings (#9419)
    
    * API, Core: Fix errorprone warnings
    
    * Address comments
    
    * Remove comment
---
 api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java          | 1 +
 api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java      | 1 +
 core/src/main/java/org/apache/iceberg/DeleteFileIndex.java              | 1 +
 .../java/org/apache/iceberg/avro/AvroWithPartnerByStructureVisitor.java | 2 +-
 .../org/apache/iceberg/deletes/SortingPositionOnlyDeleteWriter.java     | 1 +
 5 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java 
b/api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java
index 5c25fc8191..1bb5a1dc4e 100644
--- a/api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java
+++ b/api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java
@@ -166,6 +166,7 @@ public class CharSequenceSet implements Set<CharSequence>, 
Serializable {
     wrapperSet.clear();
   }
 
+  @SuppressWarnings("CollectionUndefinedEquality")
   @Override
   public boolean equals(Object other) {
     if (this == other) {
diff --git a/api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java 
b/api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java
index e022120602..fcccb9eac0 100644
--- a/api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java
+++ b/api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java
@@ -44,6 +44,7 @@ public class CharSequenceWrapper implements CharSequence, 
Serializable {
   }
 
   @Override
+  @SuppressWarnings("UndefinedEquals")
   public boolean equals(Object other) {
     if (this == other) {
       return true;
diff --git a/core/src/main/java/org/apache/iceberg/DeleteFileIndex.java 
b/core/src/main/java/org/apache/iceberg/DeleteFileIndex.java
index 6c69a6e013..e401a8179e 100644
--- a/core/src/main/java/org/apache/iceberg/DeleteFileIndex.java
+++ b/core/src/main/java/org/apache/iceberg/DeleteFileIndex.java
@@ -161,6 +161,7 @@ class DeleteFileIndex {
     return deletes == null ? EMPTY_DELETES : deletes.filter(seq, dataFile);
   }
 
+  @SuppressWarnings("CollectionUndefinedEquality")
   private DeleteFile[] findPathDeletes(long seq, DataFile dataFile) {
     if (posDeletesByPath == null) {
       return EMPTY_DELETES;
diff --git 
a/core/src/main/java/org/apache/iceberg/avro/AvroWithPartnerByStructureVisitor.java
 
b/core/src/main/java/org/apache/iceberg/avro/AvroWithPartnerByStructureVisitor.java
index 28cde9be17..2c080005d8 100644
--- 
a/core/src/main/java/org/apache/iceberg/avro/AvroWithPartnerByStructureVisitor.java
+++ 
b/core/src/main/java/org/apache/iceberg/avro/AvroWithPartnerByStructureVisitor.java
@@ -109,7 +109,7 @@ public abstract class AvroWithPartnerByStructureVisitor<P, 
T> {
         // types match according to the following pattern:
         // Before NULL, branch type i in the union maps to struct field i + 1.
         // After NULL, branch type i in the union maps to struct field i.
-        int structFieldIndex = (encounteredNull) ? i : i + 1;
+        int structFieldIndex = encounteredNull ? i : i + 1;
         if (types.get(i).getType() == Schema.Type.NULL) {
           visit(visitor.nullType(), types.get(i), visitor);
           encounteredNull = true;
diff --git 
a/core/src/main/java/org/apache/iceberg/deletes/SortingPositionOnlyDeleteWriter.java
 
b/core/src/main/java/org/apache/iceberg/deletes/SortingPositionOnlyDeleteWriter.java
index 3fc6c5eec9..c63f313010 100644
--- 
a/core/src/main/java/org/apache/iceberg/deletes/SortingPositionOnlyDeleteWriter.java
+++ 
b/core/src/main/java/org/apache/iceberg/deletes/SortingPositionOnlyDeleteWriter.java
@@ -116,6 +116,7 @@ public class SortingPositionOnlyDeleteWriter<T>
     return new DeleteWriteResult(deleteFiles, referencedDataFiles);
   }
 
+  @SuppressWarnings("CollectionUndefinedEquality")
   private DeleteWriteResult writeDeletes(Collection<CharSequence> paths) 
throws IOException {
     FileWriter<PositionDelete<T>, DeleteWriteResult> writer = writers.get();