This is an automated email from the ASF dual-hosted git repository.
honahx pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
The following commit(s) were added to refs/heads/main by this push:
new e1018e5 fix all falsey transforms (#280)
e1018e5 is described below
commit e1018e5005eb777cf0741e190b69f72d3d4256f1
Author: Sung Yun <[email protected]>
AuthorDate: Thu Jan 18 20:26:00 2024 -0500
fix all falsey transforms (#280)
---
pyiceberg/transforms.py | 6 +++---
tests/test_transforms.py | 20 ++++++++++++++++++++
2 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/pyiceberg/transforms.py b/pyiceberg/transforms.py
index 4386547..9f499a3 100644
--- a/pyiceberg/transforms.py
+++ b/pyiceberg/transforms.py
@@ -382,7 +382,7 @@ class MonthTransform(TimeTransform[S]):
else:
raise ValueError(f"Cannot apply month transform for type:
{source}")
- return lambda v: month_func(v) if v else None
+ return lambda v: month_func(v) if v is not None else None
def can_transform(self, source: IcebergType) -> bool:
return isinstance(source, (DateType, TimestampType, TimestamptzType))
@@ -424,7 +424,7 @@ class DayTransform(TimeTransform[S]):
else:
raise ValueError(f"Cannot apply day transform for type: {source}")
- return lambda v: day_func(v) if v else None
+ return lambda v: day_func(v) if v is not None else None
def can_transform(self, source: IcebergType) -> bool:
return isinstance(source, (DateType, TimestampType, TimestamptzType))
@@ -464,7 +464,7 @@ class HourTransform(TimeTransform[S]):
else:
raise ValueError(f"Cannot apply hour transform for type: {source}")
- return lambda v: hour_func(v) if v else None
+ return lambda v: hour_func(v) if v is not None else None
def can_transform(self, source: IcebergType) -> bool:
return isinstance(source, (TimestampType, TimestamptzType))
diff --git a/tests/test_transforms.py b/tests/test_transforms.py
index d4910cc..4fea773 100644
--- a/tests/test_transforms.py
+++ b/tests/test_transforms.py
@@ -236,6 +236,19 @@ def test_negative_value_to_human_string(negative_value:
int, time_transform: Tim
assert time_transform.to_human_string(TimestampType(), negative_value) ==
expected
[email protected](
+ "zero_value,time_transform,expected",
+ [
+ (0, YearTransform(), "1970"),
+ (0, MonthTransform(), "1970-01"),
+ (0, DayTransform(), "1970-01-01"),
+ (0, HourTransform(), "1970-01-01-00"),
+ ],
+)
+def test_zero_value_to_human_string(zero_value: int, time_transform:
TimeTransform[Any], expected: str) -> None:
+ assert time_transform.to_human_string(TimestampType(), zero_value) ==
expected
+
+
@pytest.mark.parametrize(
"type_var",
[
@@ -274,6 +287,12 @@ def test_time_methods(type_var: PrimitiveType) -> None:
(MonthTransform(), TimestamptzType(), -1, -1),
(DayTransform(), TimestampType(), 1512151975038194, 17501),
(DayTransform(), TimestampType(), -1, -1),
+ (YearTransform(), DateType(), 0, 0),
+ (MonthTransform(), DateType(), 0, 0),
+ (DayTransform(), DateType(), 0, 0),
+ (YearTransform(), TimestampType(), 0, 0),
+ (MonthTransform(), TimestampType(), 0, 0),
+ (DayTransform(), TimestampType(), 0, 0),
],
)
def test_time_apply_method(transform: TimeTransform[Any], type_var:
PrimitiveType, value: int, expected: int) -> None:
@@ -291,6 +310,7 @@ def test_hour_method(type_var: PrimitiveType) -> None:
assert HourTransform().can_transform(type_var)
assert HourTransform().result_type(type_var) == IntegerType()
assert HourTransform().transform(type_var)(1512151975038194) == 420042 #
type: ignore
+ assert HourTransform().transform(type_var)(0) == 0 # type: ignore
assert HourTransform().dedup_name == "time"
