This is an automated email from the ASF dual-hosted git repository.

etudenhoefner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/main by this push:
     new 97e034b2ce Flink: Remove deprecated RowDataUtil.clone method (#10902)
97e034b2ce is described below

commit 97e034b2cec9408a6f792c410a8eb8dddb452e14
Author: Piotr Findeisen <[email protected]>
AuthorDate: Wed Aug 7 16:08:16 2024 +0200

    Flink: Remove deprecated RowDataUtil.clone method (#10902)
    
    Scheduled for removal in 1.7.0.
---
 .../org/apache/iceberg/flink/data/RowDataUtil.java     | 18 ------------------
 .../org/apache/iceberg/flink/data/RowDataUtil.java     | 18 ------------------
 .../org/apache/iceberg/flink/data/RowDataUtil.java     | 18 ------------------
 3 files changed, 54 deletions(-)

diff --git 
a/flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
 
b/flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
index 3a8f5ccc6c..4bd85bbd97 100644
--- 
a/flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
+++ 
b/flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
@@ -102,22 +102,4 @@ public class RowDataUtil {
 
     return ret;
   }
-
-  /**
-   * @deprecated will be removed in 1.7.0; Not reusing FieldGetter in this 
method could lead to
-   *     performance degradation, use {@link #clone(RowData, RowData, RowType, 
TypeSerializer[],
-   *     RowData.FieldGetter[])} instead.
-   */
-  @Deprecated
-  public static RowData clone(
-      RowData from, RowData reuse, RowType rowType, TypeSerializer[] 
fieldSerializers) {
-    RowData.FieldGetter[] fieldGetters = new 
RowData.FieldGetter[rowType.getFieldCount()];
-    for (int i = 0; i < rowType.getFieldCount(); ++i) {
-      if (!from.isNullAt(i)) {
-        fieldGetters[i] = RowData.createFieldGetter(rowType.getTypeAt(i), i);
-      }
-    }
-
-    return clone(from, reuse, rowType, fieldSerializers, fieldGetters);
-  }
 }
diff --git 
a/flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
 
b/flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
index 3a8f5ccc6c..4bd85bbd97 100644
--- 
a/flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
+++ 
b/flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
@@ -102,22 +102,4 @@ public class RowDataUtil {
 
     return ret;
   }
-
-  /**
-   * @deprecated will be removed in 1.7.0; Not reusing FieldGetter in this 
method could lead to
-   *     performance degradation, use {@link #clone(RowData, RowData, RowType, 
TypeSerializer[],
-   *     RowData.FieldGetter[])} instead.
-   */
-  @Deprecated
-  public static RowData clone(
-      RowData from, RowData reuse, RowType rowType, TypeSerializer[] 
fieldSerializers) {
-    RowData.FieldGetter[] fieldGetters = new 
RowData.FieldGetter[rowType.getFieldCount()];
-    for (int i = 0; i < rowType.getFieldCount(); ++i) {
-      if (!from.isNullAt(i)) {
-        fieldGetters[i] = RowData.createFieldGetter(rowType.getTypeAt(i), i);
-      }
-    }
-
-    return clone(from, reuse, rowType, fieldSerializers, fieldGetters);
-  }
 }
diff --git 
a/flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
 
b/flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
index 3a8f5ccc6c..4bd85bbd97 100644
--- 
a/flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
+++ 
b/flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/RowDataUtil.java
@@ -102,22 +102,4 @@ public class RowDataUtil {
 
     return ret;
   }
-
-  /**
-   * @deprecated will be removed in 1.7.0; Not reusing FieldGetter in this 
method could lead to
-   *     performance degradation, use {@link #clone(RowData, RowData, RowType, 
TypeSerializer[],
-   *     RowData.FieldGetter[])} instead.
-   */
-  @Deprecated
-  public static RowData clone(
-      RowData from, RowData reuse, RowType rowType, TypeSerializer[] 
fieldSerializers) {
-    RowData.FieldGetter[] fieldGetters = new 
RowData.FieldGetter[rowType.getFieldCount()];
-    for (int i = 0; i < rowType.getFieldCount(); ++i) {
-      if (!from.isNullAt(i)) {
-        fieldGetters[i] = RowData.createFieldGetter(rowType.getTypeAt(i), i);
-      }
-    }
-
-    return clone(from, reuse, rowType, fieldSerializers, fieldGetters);
-  }
 }

Reply via email to