This is an automated email from the ASF dual-hosted git repository.
singhpk234 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/main by this push:
new 94d9287b7a Core: Minor code improvements (#14489)
94d9287b7a is described below
commit 94d9287b7a3b7474aa0776c315ec000fc97de329
Author: Eduard Tudenhoefner <[email protected]>
AuthorDate: Mon Nov 3 16:45:18 2025 +0100
Core: Minor code improvements (#14489)
---
api/src/main/java/org/apache/iceberg/PartitionSpec.java | 8 ++------
.../iceberg/rest/responses/FetchPlanningResultResponseParser.java | 6 +-----
.../iceberg/rest/responses/FetchScanTasksResponseParser.java | 6 +-----
.../iceberg/rest/responses/PlanTableScanResponseParser.java | 5 +----
4 files changed, 5 insertions(+), 20 deletions(-)
diff --git a/api/src/main/java/org/apache/iceberg/PartitionSpec.java
b/api/src/main/java/org/apache/iceberg/PartitionSpec.java
index f059c928a9..30b9e2bc61 100644
--- a/api/src/main/java/org/apache/iceberg/PartitionSpec.java
+++ b/api/src/main/java/org/apache/iceberg/PartitionSpec.java
@@ -19,8 +19,8 @@
package org.apache.iceberg;
import java.io.Serializable;
-import java.io.UnsupportedEncodingException;
import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
import java.util.AbstractMap;
import java.util.Arrays;
import java.util.List;
@@ -203,11 +203,7 @@ public class PartitionSpec implements Serializable {
}
private String escape(String string) {
- try {
- return URLEncoder.encode(string, "UTF-8");
- } catch (UnsupportedEncodingException e) {
- throw new RuntimeException(e);
- }
+ return URLEncoder.encode(string, StandardCharsets.UTF_8);
}
public String partitionToPath(StructLike data) {
diff --git
a/core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponseParser.java
b/core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponseParser.java
index 5dcfe2d59a..925e0f5746 100644
---
a/core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponseParser.java
+++
b/core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponseParser.java
@@ -69,11 +69,7 @@ public class FetchPlanningResultResponseParser {
String json, Map<Integer, PartitionSpec> specsById, boolean
caseSensitive) {
Preconditions.checkArgument(
json != null, "Invalid fetchPlanningResult response: null or empty");
- return JsonUtil.parse(
- json,
- node -> {
- return fromJson(node, specsById, caseSensitive);
- });
+ return JsonUtil.parse(json, node -> fromJson(node, specsById,
caseSensitive));
}
public static FetchPlanningResultResponse fromJson(
diff --git
a/core/src/main/java/org/apache/iceberg/rest/responses/FetchScanTasksResponseParser.java
b/core/src/main/java/org/apache/iceberg/rest/responses/FetchScanTasksResponseParser.java
index f54243b877..bfc8a08b90 100644
---
a/core/src/main/java/org/apache/iceberg/rest/responses/FetchScanTasksResponseParser.java
+++
b/core/src/main/java/org/apache/iceberg/rest/responses/FetchScanTasksResponseParser.java
@@ -64,11 +64,7 @@ public class FetchScanTasksResponseParser {
static FetchScanTasksResponse fromJson(
String json, Map<Integer, PartitionSpec> specsById, boolean
caseSensitive) {
Preconditions.checkArgument(json != null, "Cannot parse fetchScanTasks
response from null");
- return JsonUtil.parse(
- json,
- node -> {
- return fromJson(node, specsById, caseSensitive);
- });
+ return JsonUtil.parse(json, node -> fromJson(node, specsById,
caseSensitive));
}
public static FetchScanTasksResponse fromJson(
diff --git
a/core/src/main/java/org/apache/iceberg/rest/responses/PlanTableScanResponseParser.java
b/core/src/main/java/org/apache/iceberg/rest/responses/PlanTableScanResponseParser.java
index 523770e6cc..b99cd369d8 100644
---
a/core/src/main/java/org/apache/iceberg/rest/responses/PlanTableScanResponseParser.java
+++
b/core/src/main/java/org/apache/iceberg/rest/responses/PlanTableScanResponseParser.java
@@ -76,10 +76,7 @@ public class PlanTableScanResponseParser {
Preconditions.checkArgument(
json != null, "Cannot parse planTableScan response from empty or null
object");
return JsonUtil.parse(
- json,
- node -> {
- return PlanTableScanResponseParser.fromJson(node, specsById,
caseSensitive);
- });
+ json, node -> PlanTableScanResponseParser.fromJson(node, specsById,
caseSensitive));
}
public static PlanTableScanResponse fromJson(