This is an automated email from the ASF dual-hosted git repository.
kevinjqliu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
The following commit(s) were added to refs/heads/main by this push:
new d6e978cd0 Makefile: apply PYTHON_ARG override in all uv commands
(#2735)
d6e978cd0 is described below
commit d6e978cd04e92aae00c40140958b26c85c1128c4
Author: Kevin Liu <[email protected]>
AuthorDate: Tue Nov 11 15:07:03 2025 -0800
Makefile: apply PYTHON_ARG override in all uv commands (#2735)
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
Follow up to #2601
Apply `PYTHON_ARG` override to all `uv` commands`
## Are these changes tested?
Yes
Override to use python 3.13
```
export PYTHON=3.13
make setup-venv
make install
make docs-serve
```
Unset override and verify it uses system default, python 3.12
```
unset PYTHON
make setup-venv
make test
```
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
No
---
Makefile | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/Makefile b/Makefile
index ba8d11904..f1f7874ea 100644
--- a/Makefile
+++ b/Makefile
@@ -32,9 +32,9 @@ else
endif
ifeq ($(COVERAGE),1)
- TEST_RUNNER = uv run python -m coverage run --parallel-mode
--source=pyiceberg -m
+ TEST_RUNNER = uv run $(PYTHON_ARG) python -m coverage run --parallel-mode
--source=pyiceberg -m
else
- TEST_RUNNER = uv run python -m
+ TEST_RUNNER = uv run $(PYTHON_ARG) python -m
endif
ifeq ($(KEEP_COMPOSE),1)
@@ -70,7 +70,7 @@ setup-venv: ## Create virtual environment
uv venv $(PYTHON_ARG)
install-dependencies: setup-venv ## Install all dependencies including extras
- uv sync --all-extras
+ uv sync $(PYTHON_ARG) --all-extras
install: install-uv install-dependencies ## Install uv and dependencies
@@ -84,7 +84,7 @@ check-license: ## Check license headers
./dev/check-license
lint: ## Run code linters via prek (pre-commit hooks)
- uv run prek run -a
+ uv run $(PYTHON_ARG) prek run -a
# ===============
# Testing Section
@@ -101,7 +101,7 @@ test-integration-setup: ## Start Docker services for
integration tests
docker compose -f dev/docker-compose-integration.yml kill
docker compose -f dev/docker-compose-integration.yml rm -f
docker compose -f dev/docker-compose-integration.yml up -d --wait
- uv run python dev/provision.py
+ uv run $(PYTHON_ARG) python dev/provision.py
test-integration-exec: ## Run integration tests (excluding provision)
$(TEST_RUNNER) pytest tests/ -m integration $(PYTEST_ARGS)
@@ -133,10 +133,10 @@ test-coverage: COVERAGE=1
test-coverage: test test-integration test-s3 test-adls test-gcs
coverage-report ## Run all tests with coverage and report
coverage-report: ## Combine and report coverage
- uv run coverage combine
- uv run coverage report -m --fail-under=$(COVERAGE_FAIL_UNDER)
- uv run coverage html
- uv run coverage xml
+ uv run $(PYTHON_ARG) coverage combine
+ uv run $(PYTHON_ARG) coverage report -m
--fail-under=$(COVERAGE_FAIL_UNDER)
+ uv run $(PYTHON_ARG) coverage html
+ uv run $(PYTHON_ARG) coverage xml
# ================
# Documentation
@@ -145,13 +145,13 @@ coverage-report: ## Combine and report coverage
##@ Documentation
docs-install: ## Install docs dependencies (included in default groups)
- uv sync --group docs
+ uv sync $(PYTHON_ARG) --group docs
docs-serve: ## Serve local docs preview (hot reload)
- uv run mkdocs serve -f mkdocs/mkdocs.yml
+ uv run $(PYTHON_ARG) mkdocs serve -f mkdocs/mkdocs.yml
docs-build: ## Build the static documentation site
- uv run mkdocs build -f mkdocs/mkdocs.yml --strict
+ uv run $(PYTHON_ARG) mkdocs build -f mkdocs/mkdocs.yml --strict
# ===================
# Project Maintenance
