This is an automated email from the ASF dual-hosted git repository.
huaxingao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg.git
The following commit(s) were added to refs/heads/main by this push:
new baee887711 fix typo in assert message (#14855)
baee887711 is described below
commit baee8877117b10b761c1c9c261512b255ac7e739
Author: Huaxin Gao <[email protected]>
AuthorDate: Tue Dec 16 10:57:13 2025 -0800
fix typo in assert message (#14855)
---
.../iceberg/expressions/TestInclusiveManifestEvaluator.java | 6 +++---
.../iceberg/expressions/TestInclusiveMetricsEvaluator.java | 6 +++---
.../TestInclusiveMetricsEvaluatorWithExtract.java | 6 +++---
.../TestInclusiveMetricsEvaluatorWithTransforms.java | 6 +++---
.../org/apache/iceberg/data/TestMetricsRowGroupFilter.java | 12 ++++++------
.../apache/iceberg/parquet/TestDictionaryRowGroupFilter.java | 12 ++++++------
6 files changed, 24 insertions(+), 24 deletions(-)
diff --git
a/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveManifestEvaluator.java
b/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveManifestEvaluator.java
index 068c862e2b..6c4944e9cd 100644
---
a/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveManifestEvaluator.java
+++
b/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveManifestEvaluator.java
@@ -353,7 +353,7 @@ public class TestInclusiveManifestEvaluator {
shouldRead =
ManifestEvaluator.forRowFilter(lessThan("id", INT_MAX_VALUE), SPEC,
true).eval(FILE);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@Test
@@ -395,7 +395,7 @@ public class TestInclusiveManifestEvaluator {
shouldRead =
ManifestEvaluator.forRowFilter(greaterThan("id", INT_MAX_VALUE - 4),
SPEC, true).eval(FILE);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@Test
@@ -418,7 +418,7 @@ public class TestInclusiveManifestEvaluator {
shouldRead =
ManifestEvaluator.forRowFilter(greaterThanOrEqual("id", INT_MAX_VALUE
- 4), SPEC, true)
.eval(FILE);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@Test
diff --git
a/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java
b/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java
index 2f4fbf3957..8ae34c4c16 100644
---
a/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java
+++
b/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java
@@ -474,7 +474,7 @@ public class TestInclusiveMetricsEvaluator {
assertThat(shouldRead).as("Should read: one possible id").isTrue();
shouldRead = new InclusiveMetricsEvaluator(SCHEMA, lessThan("id",
INT_MAX_VALUE)).eval(FILE);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@Test
@@ -513,7 +513,7 @@ public class TestInclusiveMetricsEvaluator {
shouldRead =
new InclusiveMetricsEvaluator(SCHEMA, greaterThan("id", INT_MAX_VALUE
- 4)).eval(FILE);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@Test
@@ -535,7 +535,7 @@ public class TestInclusiveMetricsEvaluator {
shouldRead =
new InclusiveMetricsEvaluator(SCHEMA, greaterThanOrEqual("id",
INT_MAX_VALUE - 4))
.eval(FILE);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@Test
diff --git
a/core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithExtract.java
b/core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithExtract.java
index 1ee0a7ac63..03c1c12f4f 100644
---
a/core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithExtract.java
+++
b/core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithExtract.java
@@ -309,7 +309,7 @@ public class TestInclusiveMetricsEvaluatorWithExtract {
.isTrue();
assertThat(shouldRead(lessThan(extract("variant", "$.event_id", "long"),
INT_MAX_VALUE)))
- .as("Should read: may possible ids")
+ .as("Should read: many possible ids")
.isTrue();
}
@@ -351,7 +351,7 @@ public class TestInclusiveMetricsEvaluatorWithExtract {
.isTrue();
assertThat(shouldRead(greaterThan(extract("variant", "$.event_id",
"long"), INT_MAX_VALUE - 4)))
- .as("Should read: may possible ids")
+ .as("Should read: many possible ids")
.isTrue();
}
@@ -377,7 +377,7 @@ public class TestInclusiveMetricsEvaluatorWithExtract {
assertThat(
shouldRead(
greaterThanOrEqual(extract("variant", "$.event_id", "long"),
INT_MAX_VALUE - 4)))
- .as("Should read: may possible ids")
+ .as("Should read: many possible ids")
.isTrue();
}
diff --git
a/core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithTransforms.java
b/core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithTransforms.java
index 5632830064..41a14667ea 100644
---
a/core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithTransforms.java
+++
b/core/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluatorWithTransforms.java
@@ -368,7 +368,7 @@ public class TestInclusiveMetricsEvaluatorWithTransforms {
.isTrue();
assertThat(shouldRead(lessThan(day("ts"), INT_MAX_VALUE)))
- .as("Should read: may possible ids")
+ .as("Should read: many possible ids")
.isTrue();
}
@@ -406,7 +406,7 @@ public class TestInclusiveMetricsEvaluatorWithTransforms {
.isTrue();
assertThat(shouldRead(greaterThan(day("ts"), INT_MAX_VALUE - 4)))
- .as("Should read: may possible ids")
+ .as("Should read: many possible ids")
.isTrue();
}
@@ -425,7 +425,7 @@ public class TestInclusiveMetricsEvaluatorWithTransforms {
.isTrue();
assertThat(shouldRead(greaterThanOrEqual(day("ts"), INT_MAX_VALUE - 4)))
- .as("Should read: may possible ids")
+ .as("Should read: many possible ids")
.isTrue();
}
diff --git
a/data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java
b/data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java
index e1f9f07e7a..3cb46b309d 100644
--- a/data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java
+++ b/data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java
@@ -577,7 +577,7 @@ public class TestMetricsRowGroupFilter {
assertThat(shouldRead).as("Should read: one possible id").isTrue();
shouldRead = shouldRead(lessThan("id", INT_MAX_VALUE));
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
@@ -609,7 +609,7 @@ public class TestMetricsRowGroupFilter {
assertThat(shouldRead).as("Should read: one possible id").isTrue();
shouldRead = shouldRead(greaterThan("id", INT_MAX_VALUE - 4));
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
@@ -624,7 +624,7 @@ public class TestMetricsRowGroupFilter {
assertThat(shouldRead).as("Should read: one possible id").isTrue();
shouldRead = shouldRead(greaterThanOrEqual("id", INT_MAX_VALUE - 4));
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
@@ -713,7 +713,7 @@ public class TestMetricsRowGroupFilter {
assertThat(shouldRead).as("Should read: one possible id").isTrue();
shouldRead = shouldRead(lessThan("struct_not_null.int_field",
INT_MAX_VALUE));
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
@@ -746,7 +746,7 @@ public class TestMetricsRowGroupFilter {
assertThat(shouldRead).as("Should read: one possible id").isTrue();
shouldRead = shouldRead(greaterThan("struct_not_null.int_field",
INT_MAX_VALUE - 4));
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
@@ -762,7 +762,7 @@ public class TestMetricsRowGroupFilter {
assertThat(shouldRead).as("Should read: one possible id").isTrue();
shouldRead = shouldRead(greaterThanOrEqual("struct_not_null.int_field",
INT_MAX_VALUE - 4));
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
diff --git
a/parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java
b/parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java
index 48cc2b0992..7a15f86098 100644
---
a/parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java
+++
b/parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java
@@ -608,7 +608,7 @@ public class TestDictionaryRowGroupFilter {
shouldRead =
new ParquetDictionaryRowGroupFilter(SCHEMA, lessThan("id",
INT_MAX_VALUE))
.shouldRead(parquetSchema, rowGroupMetadata, dictionaryStore);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
@@ -656,7 +656,7 @@ public class TestDictionaryRowGroupFilter {
shouldRead =
new ParquetDictionaryRowGroupFilter(SCHEMA, greaterThan("id",
INT_MAX_VALUE - 4))
.shouldRead(parquetSchema, rowGroupMetadata, dictionaryStore);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
@@ -679,7 +679,7 @@ public class TestDictionaryRowGroupFilter {
shouldRead =
new ParquetDictionaryRowGroupFilter(SCHEMA, greaterThanOrEqual("id",
INT_MAX_VALUE - 4))
.shouldRead(parquetSchema, rowGroupMetadata, dictionaryStore);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
@@ -835,7 +835,7 @@ public class TestDictionaryRowGroupFilter {
new ParquetDictionaryRowGroupFilter(
SCHEMA, lessThan("struct_not_null.int_field", INT_MAX_VALUE))
.shouldRead(parquetSchema, rowGroupMetadata, dictionaryStore);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
@@ -891,7 +891,7 @@ public class TestDictionaryRowGroupFilter {
new ParquetDictionaryRowGroupFilter(
SCHEMA, greaterThan("struct_not_null.int_field", INT_MAX_VALUE
- 4))
.shouldRead(parquetSchema, rowGroupMetadata, dictionaryStore);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
@@ -918,7 +918,7 @@ public class TestDictionaryRowGroupFilter {
new ParquetDictionaryRowGroupFilter(
SCHEMA, greaterThanOrEqual("struct_not_null.int_field",
INT_MAX_VALUE - 4))
.shouldRead(parquetSchema, rowGroupMetadata, dictionaryStore);
- assertThat(shouldRead).as("Should read: may possible ids").isTrue();
+ assertThat(shouldRead).as("Should read: many possible ids").isTrue();
}
@TestTemplate
