This is an automated email from the ASF dual-hosted git repository.
fokko pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
The following commit(s) were added to refs/heads/main by this push:
new 85c9cb6e Fix live reload for `make docs-serve` (#2889)
85c9cb6e is described below
commit 85c9cb6e72f93580dbcf482a38c459ecb2eac6ee
Author: Kevin Liu <[email protected]>
AuthorDate: Tue Jan 6 17:50:51 2026 -0500
Fix live reload for `make docs-serve` (#2889)
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
`make docs-serve` use to live reload on change. This PR fixes the
underlying issue, thanks to
https://github.com/mkdocs/mkdocs/issues/4032#issuecomment-3591002290
From the same thread, it looks like the underlying issue the
`click>8.2.1` which we're using (#2762). click 8.3.2 should fix the
issue,
https://github.com/mkdocs/mkdocs/issues/4032#issuecomment-3644653585
but it doesnt hurt to always explicitly call `--livereload`
## Are these changes tested?
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label.
-->
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 106f499a..22574c5e 100644
--- a/Makefile
+++ b/Makefile
@@ -148,7 +148,7 @@ docs-install: ## Install docs dependencies (included in
default groups)
uv sync $(PYTHON_ARG) --group docs
docs-serve: ## Serve local docs preview (hot reload)
- uv run $(PYTHON_ARG) mkdocs serve -f mkdocs/mkdocs.yml
+ uv run $(PYTHON_ARG) mkdocs serve -f mkdocs/mkdocs.yml --livereload
docs-build: ## Build the static documentation site
uv run $(PYTHON_ARG) mkdocs build -f mkdocs/mkdocs.yml --strict
