(iceberg-go) branch main updated: fix(test): TestCreateTable existence check failure (#1105)

[zeroshade]

This is an automated email from the ASF dual-hosted git repository.

zeroshade pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-go.git


The following commit(s) were added to refs/heads/main by this push:
     new 47ea028d fix(test): TestCreateTable existence check failure (#1105)
47ea028d is described below

commit 47ea028d9a9ad70adc2f3f894d1599056d905f34
Author: Andrei Tserakhau <laskoviymis...@gmail.com>
AuthorDate: Thu May 21 18:12:20 2026 +0200

    fix(test): TestCreateTable existence check failure (#1105)
    
    PR #355 renamed the table created in TestCreateTable from "test-table"
    to "test-create-table" but left the follow-up CheckTableExists and
    DropTable calls pointing at the old name. CheckTableExists returns
    false, s.True(exists) fails, the actual table is never dropped, and the
    orphan in the namespace cascades into failures for every other suite
    test via ensureNamespace.
---
 catalog/rest/rest_integration_test.go | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/catalog/rest/rest_integration_test.go 
b/catalog/rest/rest_integration_test.go
index 2b87d4ad..0d860105 100644
--- a/catalog/rest/rest_integration_test.go
+++ b/catalog/rest/rest_integration_test.go
@@ -181,11 +181,11 @@ func (s *RestIntegrationSuite) TestCreateTable() {
        s.Equal("s3://warehouse/rest-integration-test/test-create-table", 
tbl.Location())
        s.Equal("baz", tbl.Properties()["foobar"])
 
-       exists, err := s.cat.CheckTableExists(s.ctx, 
catalog.ToIdentifier(TestNamespaceIdent, "test-table"))
+       exists, err := s.cat.CheckTableExists(s.ctx, 
catalog.ToIdentifier(TestNamespaceIdent, "test-create-table"))
        s.Require().NoError(err)
        s.True(exists)
 
-       s.Require().NoError(s.cat.DropTable(s.ctx, 
catalog.ToIdentifier(TestNamespaceIdent, "test-table")))
+       s.Require().NoError(s.cat.DropTable(s.ctx, 
catalog.ToIdentifier(TestNamespaceIdent, "test-create-table")))
 }
 
 func (s *RestIntegrationSuite) TestCreateView() {
@@ -295,13 +295,13 @@ func (s *RestIntegrationSuite) TestWriteCommitTable() {
        const expectedLocation = 
"s3://warehouse/rest-integration-test/test-write-commit-table"
 
        tbl, err := s.cat.CreateTable(s.ctx,
-               catalog.ToIdentifier(TestNamespaceIdent, "test-table-2"),
+               catalog.ToIdentifier(TestNamespaceIdent, 
"test-write-commit-table"),
                tableSchemaNested)
        s.Require().NoError(err)
        s.Require().NotNil(tbl)
 
        defer func() {
-               s.Require().NoError(s.cat.DropTable(s.ctx, 
catalog.ToIdentifier(TestNamespaceIdent, "test-table-2")))
+               s.Require().NoError(s.cat.DropTable(s.ctx, 
catalog.ToIdentifier(TestNamespaceIdent, "test-write-commit-table")))
        }()
 
        s.Equal(expectedLocation, tbl.Location())