This is an automated email from the ASF dual-hosted git repository.
kevinjqliu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
The following commit(s) were added to refs/heads/main by this push:
new a24af2301 REST: Add integration test for views (#3406)
a24af2301 is described below
commit a24af23012f9c7767499efbeeb4dd524e0353d3f
Author: Yuya Ebihara <[email protected]>
AuthorDate: Sun May 24 12:00:20 2026 +0900
REST: Add integration test for views (#3406)
# Rationale for this change
Improve test coverage of views in REST catalog.
## Are these changes tested?
Yes
## Are there any user-facing changes?
No
---
tests/conftest.py | 5 ++++
tests/integration/test_catalog.py | 52 +++++++++++++++++++++++++++++++++++++++
2 files changed, 57 insertions(+)
diff --git a/tests/conftest.py b/tests/conftest.py
index 68db3d254..d7cdba012 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -2510,6 +2510,11 @@ def clean_up(test_catalog: Catalog) -> None:
if "my_iceberg_database-" in database_name:
for identifier in test_catalog.list_tables(database_name):
test_catalog.drop_table(identifier)
+ try:
+ for identifier in test_catalog.list_views(database_name):
+ test_catalog.drop_view(identifier)
+ except NotImplementedError:
+ pass
test_catalog.drop_namespace(database_name)
diff --git a/tests/integration/test_catalog.py
b/tests/integration/test_catalog.py
index 751dbe047..4188ad83d 100644
--- a/tests/integration/test_catalog.py
+++ b/tests/integration/test_catalog.py
@@ -19,6 +19,7 @@ import os
import uuid
from collections.abc import Generator
from pathlib import Path, PosixPath
+from typing import Any
import pytest
from pytest_lazy_fixtures import lf
@@ -44,6 +45,8 @@ from pyiceberg.table.metadata import INITIAL_SPEC_ID
from pyiceberg.table.sorting import INITIAL_SORT_ORDER_ID, SortField, SortOrder
from pyiceberg.transforms import BucketTransform, DayTransform,
IdentityTransform
from pyiceberg.types import IntegerType, LongType, NestedField, TimestampType,
UUIDType
+from pyiceberg.view import View
+from pyiceberg.view.metadata import ViewMetadata
from tests.conftest import (
clean_up,
does_support_atomic_concurrent_updates,
@@ -617,6 +620,55 @@ def test_register_table_existing(test_catalog: Catalog,
table_schema_nested: Sch
test_catalog.register_table(identifier,
metadata_location=table.metadata_location)
[email protected]
+def test_rest_list_views(
+ rest_catalog: RestCatalog, example_view_metadata_v1: dict[str, Any],
database_name: str, view_name: str
+) -> None:
+ identifier = (database_name, view_name)
+
+ rest_catalog.create_namespace_if_not_exists(database_name)
+ view = View(identifier,
ViewMetadata.model_validate(example_view_metadata_v1))
+
+ assert identifier not in rest_catalog.list_views(database_name)
+
+ rest_catalog.create_view(identifier, view.schema(), view.current_version())
+
+ assert identifier in rest_catalog.list_views(database_name)
+
+
[email protected]
+def test_rest_create_view(
+ rest_catalog: RestCatalog, example_view_metadata_v1: dict[str, Any],
database_name: str, view_name: str
+) -> None:
+ identifier = (database_name, view_name)
+
+ rest_catalog.create_namespace_if_not_exists(database_name)
+ view = View(identifier,
ViewMetadata.model_validate(example_view_metadata_v1))
+
+ assert not rest_catalog.view_exists(identifier)
+
+ rest_catalog.create_view(identifier, view.schema(), view.current_version())
+
+ assert rest_catalog.view_exists(identifier)
+ assert rest_catalog.load_view(identifier).schema() == view.schema()
+
+
[email protected]
+def test_rest_drop_view(
+ rest_catalog: RestCatalog, example_view_metadata_v1: dict[str, Any],
database_name: str, view_name: str
+) -> None:
+ identifier = (database_name, view_name)
+
+ rest_catalog.create_namespace_if_not_exists(database_name)
+ view = View(identifier,
ViewMetadata.model_validate(example_view_metadata_v1))
+
+ rest_catalog.create_view(identifier, view.schema(), view.current_version())
+ assert rest_catalog.view_exists(identifier)
+
+ rest_catalog.drop_view(identifier)
+ assert not rest_catalog.view_exists(identifier)
+
+
@pytest.mark.integration
@pytest.mark.skip(reason="Requires Iceberg REST Fixtures 1.11.x")
def test_rest_custom_namespace_separator(rest_catalog: RestCatalog,
table_schema_simple: Schema) -> None:
