This is an automated email from the ASF dual-hosted git repository.
kevinjqliu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
The following commit(s) were added to refs/heads/main by this push:
new e4869850b REST: Allow Identifier type in `drop_view` method (#3408)
e4869850b is described below
commit e4869850b5632b29bc65cd2d549bfda9fb22d27c
Author: Yuya Ebihara <[email protected]>
AuthorDate: Mon May 25 01:37:58 2026 +0900
REST: Allow Identifier type in `drop_view` method (#3408)
# Rationale for this change
Fix the warning message in the IDE.
The base class and other classes use the `str | Identifier` style in the
`drop_view` method.
I also confirmed that other methods in the REST catalog class use `str |
Identifier` for identifiers.
## Are these changes tested?
N/A
## Are there any user-facing changes?
No
<!-- In the case of user-facing changes, please add the changelog label.
-->
---
pyiceberg/catalog/rest/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyiceberg/catalog/rest/__init__.py
b/pyiceberg/catalog/rest/__init__.py
index 7a09e376f..d085c6fd8 100644
--- a/pyiceberg/catalog/rest/__init__.py
+++ b/pyiceberg/catalog/rest/__init__.py
@@ -1461,7 +1461,7 @@ class RestCatalog(Catalog):
@retry(**_RETRY_ARGS)
@override
- def drop_view(self, identifier: str) -> None:
+ def drop_view(self, identifier: str | Identifier) -> None:
self._check_endpoint(Capability.V1_DELETE_VIEW)
response = self._session.delete(
self.url(Endpoints.drop_view, prefixed=True,
**self._split_identifier_for_path(identifier, IdentifierKind.VIEW)),
