This is an automated email from the ASF dual-hosted git repository.
kevinjqliu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
The following commit(s) were added to refs/heads/main by this push:
new 2e5955a60 Remove stale VariantType transform TODO (#3742)
2e5955a60 is described below
commit 2e5955a6032d963b4861044ac4b952e7640051ce
Author: Junwang Zhao <[email protected]>
AuthorDate: Mon Aug 3 02:02:40 2026 +0800
Remove stale VariantType transform TODO (#3742)
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
VariantType is modeled separately from PrimitiveType and rejected by
primitive-scoped transforms in apache/iceberg#11324.
## Are these changes tested?
Just removed a stale TODO comment, no tests required.
## Are there any user-facing changes?
Nope.
<!-- In the case of user-facing changes, please add the changelog label.
-->
---
pyiceberg/transforms.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/pyiceberg/transforms.py b/pyiceberg/transforms.py
index cd0d7cebc..5e0027a82 100644
--- a/pyiceberg/transforms.py
+++ b/pyiceberg/transforms.py
@@ -719,7 +719,6 @@ class IdentityTransform(Transform[S, S]):
return lambda v: v
def can_transform(self, source: IcebergType) -> bool:
- # TODO: disallow VariantType when PyIceberg supports it.
return source.is_primitive and not isinstance(source, (GeographyType,
GeometryType))
def result_type(self, source: IcebergType) -> IcebergType:
