This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-3407-b154603a710d730d2f43f8af4db257cc137237ef in repository https://gitbox.apache.org/repos/asf/iceberg-rust.git
commit ec672525d6c225f080f9334a3c2744548a17d96c Author: NoahKusaba <[email protected]> AuthorDate: Tue Oct 13 08:51:05 2026 +0000 refactor(catalog-loader): rename CatalogBuilderFactory to BoxedCatalogBuilderFactory (#3407) The factories in the registry return a Box<dyn BoxedCatalogBuilder>, not a CatalogBuilder, so name the alias after the trait it produces. Suggested in review of #3286. --- crates/catalog/loader/src/lib.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/catalog/loader/src/lib.rs b/crates/catalog/loader/src/lib.rs index 3993de676..cfb2f3270 100644 --- a/crates/catalog/loader/src/lib.rs +++ b/crates/catalog/loader/src/lib.rs @@ -28,11 +28,11 @@ use iceberg_catalog_rest::RestCatalogBuilder; use iceberg_catalog_s3tables::S3TablesCatalogBuilder; use iceberg_catalog_sql::SqlCatalogBuilder; -/// A CatalogBuilderFactory creating a new catalog builder. -type CatalogBuilderFactory = fn() -> Box<dyn BoxedCatalogBuilder>; +/// Creates a new catalog builder, boxed as a [`BoxedCatalogBuilder`]. +type BoxedCatalogBuilderFactory = fn() -> Box<dyn BoxedCatalogBuilder>; -/// A registry of catalog builders. -static CATALOG_REGISTRY: &[(&str, CatalogBuilderFactory)] = &[ +/// Maps each catalog type to the factory for its builder. +static CATALOG_REGISTRY: &[(&str, BoxedCatalogBuilderFactory)] = &[ ("rest", || Box::new(RestCatalogBuilder::default())), ("glue", || Box::new(GlueCatalogBuilder::default())), ("s3tables", || Box::new(S3TablesCatalogBuilder::default())),
