poiug07 commented on code in PR #1897:
URL: https://github.com/apache/iggy/pull/1897#discussion_r2160345519
##########
foreign/go/contracts/messages.go:
##########
@@ -32,10 +32,10 @@ type FetchMessagesRequest struct {
}
type FetchMessagesResponse struct {
- PartitionId int
+ PartitionId uint32
CurrentOffset uint64
- Messages []MessageResponse
- MessageCount int
+ MessageCount uint32
+ Messages []IggyMessage
}
type MessageResponse struct {
Review Comment:
Agree. Will remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
