cstruct commented on code in PR #2169:
URL: https://github.com/apache/iggy/pull/2169#discussion_r2349192875
##########
foreign/python/src/consumer.rs:
##########
@@ -129,6 +130,13 @@ impl IggyConsumer {
})
}
+ /// Asynchronously iterate over `ReceiveMessage`s.
+
#[gen_stub(override_return_type(type_repr="collections.abc.AsyncIterator[ReceiveMessage]",
imports=("collections.abc")))]
+ fn iter<'a>(&self) -> ReceiveMessageIterator {
Review Comment:
I don't think so, I thought about it as well but landed on having a `iter`
method because I thought it read better. I don't have strong feelings about
this so am open to changing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
