chiradip commented on PR #2245: URL: https://github.com/apache/iggy/pull/2245#issuecomment-3392719399
> The builders for the async and blocking clients are duplicated. It would be good to have a common implementation since most (if not all) options will be the same. Also, the builder currently includes options that aren’t supported by the clients. I think we should keep the builder minimal for now and only add new options once the corresponding implementation is in place. --- Agreed. There are other duplication between async and blocking clients like https://github.com/apache/iggy/issues/2224, I think its better to address that later at once, or at similar time period. As far as unsupported parameters in builder, if you re talking about connection pooling, I am going to work on right away. Also they are optional. I would like to reduce the cycle of going back and forth to support connection pooling and coming back to support that in builder pattern. But I agree that optional stuff needs to be supported soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
