hubcio commented on code in PR #2393:
URL: https://github.com/apache/iggy/pull/2393#discussion_r2554944556
##########
core/common/src/types/cluster/node.rs:
##########
@@ -18,17 +18,19 @@
use crate::{
BytesSerializable, IggyError,
- types::cluster::{role::ClusterNodeRole, status::ClusterNodeStatus},
+ types::cluster::{
+ role::ClusterNodeRole, status::ClusterNodeStatus,
transport_endpoints::TransportEndpoints,
+ },
};
use bytes::{BufMut, Bytes, BytesMut};
use serde::{Deserialize, Serialize};
use std::fmt::Display;
#[derive(Debug, Deserialize, Serialize, Clone)]
pub struct ClusterNode {
- pub id: u32,
pub name: String,
- pub address: String,
+ pub ip: String,
Review Comment:
let's leave it as is - this will be serialized/deserialized by other SDKs.
if we use IpAddr, how should we serialize/deserialize it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
