This is an automated email from the ASF dual-hosted git repository. hgruszecki pushed a commit to branch codecov-comment in repository https://gitbox.apache.org/repos/asf/iggy.git
commit 2f44866de4affdd1ff0aa52c637243021f6c03c1 Author: Hubert Gruszecki <[email protected]> AuthorDate: Wed Feb 4 18:57:27 2026 +0100 fix(ci): fix example jobs, pin wiremock version, relax codecov Node setup ran for all example jobs, causing husky "not found" errors. Scope Node/Python setup to respective tasks and make husky tolerate missing binary. Pin wiremock from :latest to 3.13.2 to reduce flaky pull failures. Relax Codecov comment requirements to post even without base commit. Remove redundant pkg-config install on macOS (pre-installed). --- .github/actions/utils/setup-rust-with-cache/action.yml | 2 +- .github/workflows/_test.yml | 1 + .github/workflows/_test_examples.yml | 6 +++--- core/integration/tests/connectors/fixtures/quickwit/container.rs | 2 +- core/integration/tests/connectors/fixtures/wiremock.rs | 4 +++- foreign/node/package.json | 2 +- 6 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/actions/utils/setup-rust-with-cache/action.yml b/.github/actions/utils/setup-rust-with-cache/action.yml index f4972dfdc..12d8e96e0 100644 --- a/.github/actions/utils/setup-rust-with-cache/action.yml +++ b/.github/actions/utils/setup-rust-with-cache/action.yml @@ -49,7 +49,7 @@ runs: - name: Install system dependencies (macOS) if: runner.os == 'macOS' run: | - brew install hwloc pkg-config + brew install hwloc shell: bash - name: Setup Rust toolchain diff --git a/.github/workflows/_test.yml b/.github/workflows/_test.yml index 6631e96f1..d83ee8add 100644 --- a/.github/workflows/_test.yml +++ b/.github/workflows/_test.yml @@ -70,6 +70,7 @@ jobs: flags: rust fail_ci_if_error: false verbose: true + override_pr: ${{ github.event.pull_request.number }} # Python SDK - name: Set up Docker Buildx for Python diff --git a/.github/workflows/_test_examples.yml b/.github/workflows/_test_examples.yml index 8a611998d..5fb90f497 100644 --- a/.github/workflows/_test_examples.yml +++ b/.github/workflows/_test_examples.yml @@ -48,7 +48,7 @@ jobs: uses: ./.github/actions/utils/setup-rust-with-cache - name: Setup Node with cache for examples - if: inputs.component == 'examples-suite' + if: inputs.component == 'examples-suite' && inputs.task == 'examples-node' uses: ./.github/actions/utils/setup-node-with-cache with: node-version: "23" @@ -56,13 +56,13 @@ jobs: workspace: examples/node - name: Setup Python - if: inputs.component == 'examples-suite' + if: inputs.component == 'examples-suite' && inputs.task == 'examples-python' uses: actions/setup-python@v5 with: python-version: "3.11" - name: Cache pip - if: inputs.component == 'examples-suite' + if: inputs.component == 'examples-suite' && inputs.task == 'examples-python' uses: actions/cache@v4 with: path: ~/.cache/pip diff --git a/core/integration/tests/connectors/fixtures/quickwit/container.rs b/core/integration/tests/connectors/fixtures/quickwit/container.rs index d5133679b..ba01df3e4 100644 --- a/core/integration/tests/connectors/fixtures/quickwit/container.rs +++ b/core/integration/tests/connectors/fixtures/quickwit/container.rs @@ -31,7 +31,7 @@ use tracing::info; use uuid::Uuid; const QUICKWIT_IMAGE: &str = "quickwit/quickwit"; -const QUICKWIT_TAG: &str = "0.8.1"; +const QUICKWIT_TAG: &str = "0.8.2"; const QUICKWIT_PORT: u16 = 7280; const QUICKWIT_READY_MSG: &str = "REST server is ready"; const QUICKWIT_LISTEN_ADDRESS: &str = "0.0.0.0"; diff --git a/core/integration/tests/connectors/fixtures/wiremock.rs b/core/integration/tests/connectors/fixtures/wiremock.rs index 497243ac9..ceda81949 100644 --- a/core/integration/tests/connectors/fixtures/wiremock.rs +++ b/core/integration/tests/connectors/fixtures/wiremock.rs @@ -26,6 +26,8 @@ use testcontainers_modules::testcontainers::core::{IntoContainerPort, Mount}; use testcontainers_modules::testcontainers::runners::AsyncRunner; use testcontainers_modules::testcontainers::{ContainerAsync, GenericImage, ImageExt}; +const WIREMOCK_IMAGE: &str = "wiremock/wiremock"; +const WIREMOCK_TAG: &str = "3.13.2"; const WIREMOCK_PORT: u16 = 8080; struct WireMockContainer { @@ -41,7 +43,7 @@ impl WireMockContainer { message: format!("Failed to get current dir: {e}"), })?; - let container = GenericImage::new("wiremock/wiremock", "latest") + let container = GenericImage::new(WIREMOCK_IMAGE, WIREMOCK_TAG) .with_exposed_port(WIREMOCK_PORT.tcp()) .with_wait_for(Healthcheck(HealthWaitStrategy::default())) .with_mount(Mount::bind_mount( diff --git a/foreign/node/package.json b/foreign/node/package.json index f339c4225..dd0734df4 100644 --- a/foreign/node/package.json +++ b/foreign/node/package.json @@ -42,7 +42,7 @@ "commitlint": "commitlint --edit", "build": "tsc -p tsconfig.json", "start": "node dist/index.js", - "prepare": "husky" + "prepare": "husky || true" }, "author": "github.com/T1B0", "license": "Apache-2.0",
