This is an automated email from the ASF dual-hosted git repository.
hgruszecki pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iggy.git
The following commit(s) were added to refs/heads/master by this push:
new 278e3905e ci(go): enable auto-publish for Go SDK on post-merge (#2692)
278e3905e is described below
commit 278e3905e3e48bf42e40a6f409d4c7b7e839e295
Author: Hubert Gruszecki <[email protected]>
AuthorDate: Fri Feb 6 15:36:45 2026 +0100
ci(go): enable auto-publish for Go SDK on post-merge (#2692)
The Go SDK was the only SDK without auto-publish because it
had no version file - extract-version.sh required a manual
--go-sdk-version flag, and publish.yml used a special
go:VERSION input format.
Add foreign/go/contracts/version.go as the version source
of truth, matching how every other SDK works. Remove all
Go-specific handling from publish.yml (go:VERSION parsing,
go_sdk_version output, GO_FLAG plumbing) and the
--go-sdk-version flag from extract-version.sh. Go now uses
the same generic version_file + version_regex extraction
path as C#, Python, Node, and Java.
---
.github/config/publish.yml | 2 ++
.github/workflows/post-merge.yml | 4 +--
.github/workflows/publish.yml | 54 ++++++++--------------------------------
foreign/go/contracts/version.go | 22 ++++++++++++++++
scripts/extract-version.sh | 22 ++++------------
5 files changed, 41 insertions(+), 63 deletions(-)
diff --git a/.github/config/publish.yml b/.github/config/publish.yml
index 051464fb8..75648a542 100644
--- a/.github/config/publish.yml
+++ b/.github/config/publish.yml
@@ -121,3 +121,5 @@ components:
sdk-go:
tag_pattern:
"^foreign/go/v([0-9]+\\.[0-9]+\\.[0-9]+(?:-[0-9A-Za-z.-]+)?(?:\\+[0-9A-Za-z.-]+)?)$"
registry: none
+ version_file: "foreign/go/contracts/version.go"
+ version_regex: 'const\s+Version\s*=\s*"([^"]+)"'
diff --git a/.github/workflows/post-merge.yml b/.github/workflows/post-merge.yml
index b422fc5ff..890e94dc2 100644
--- a/.github/workflows/post-merge.yml
+++ b/.github/workflows/post-merge.yml
@@ -57,7 +57,7 @@ jobs:
chmod +x /usr/local/bin/yq
fi
- # TODO(hubcio): Add sdk-python (it has to contain `dev`), sdk-node,
sdk-java (SNAPSHOT?), sdk-go (store version in file?) when ready for edge
auto-publish
+ # TODO(hubcio): Add sdk-python (it has to contain `dev`), sdk-node,
sdk-java (SNAPSHOT?) when ready for edge auto-publish
- name: Check all components
id: check
run: |
@@ -94,7 +94,7 @@ jobs:
# Check SDKs for pre-release versions without tags
SDKS_TO_PUBLISH=""
- for sdk in sdk-csharp; do
+ for sdk in sdk-csharp sdk-go; do
VERSION=$(scripts/extract-version.sh "$sdk")
TAG=$(scripts/extract-version.sh "$sdk" --tag)
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 74f2b0207..280e423d9 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -49,7 +49,7 @@ on:
required: false
default: ""
publish_other:
- description: "Other SDKs to publish (comma-separated: python, node,
java, csharp, go:VERSION)"
+ description: "Other SDKs to publish (comma-separated: python, node,
java, csharp, go)"
type: string
required: false
default: ""
@@ -213,7 +213,6 @@ jobs:
docker_matrix: ${{ steps.mk.outputs.docker_matrix }}
docker_components: ${{ steps.mk.outputs.docker_components }}
count: ${{ steps.mk.outputs.count }}
- go_sdk_version: ${{ steps.mk.outputs.go_sdk_version }}
has_python: ${{ steps.mk.outputs.has_python }}
has_rust_crates: ${{ steps.mk.outputs.has_rust_crates }}
has_docker: ${{ steps.mk.outputs.has_docker }}
@@ -263,7 +262,6 @@ jobs:
const cfg = JSON.parse(Buffer.from(componentsB64,
'base64').toString('utf-8') || "{}");
const wants = [];
- let goVersion = '';
// Parse Rust crates
('${{ inputs.publish_crates }}').split(',').map(s =>
s.trim()).filter(Boolean).forEach(crate => {
@@ -279,14 +277,7 @@ jobs:
// Parse other SDKs
('${{ inputs.publish_other }}').split(',').map(s =>
s.trim()).filter(Boolean).forEach(sdk => {
- if (sdk.startsWith('go:')) {
- goVersion = sdk.substring(3);
- if (!/^\d+\.\d+\.\d+/.test(goVersion)) {
- core.setFailed(`Invalid Go version format: ${goVersion}
(expected: X.Y.Z)`);
- } else {
- wants.push('sdk-go');
- }
- } else if (['python','node','java','csharp'].includes(sdk)) {
+ if (['python','node','java','csharp','go'].includes(sdk)) {
wants.push(`sdk-${sdk}`);
} else {
core.warning(`Unknown SDK: ${sdk}`);
@@ -376,7 +367,6 @@ jobs:
core.setOutput('has_docker', String(dockerTargets.length > 0));
core.setOutput('count', String(targets.length));
- core.setOutput('go_sdk_version', goVersion);
core.setOutput('has_rust_crates', String(hasRustCrates));
// Check if Python SDK is in targets and extract version
@@ -446,7 +436,6 @@ jobs:
fi
TARGETS_JSON='${{ needs.plan.outputs.targets }}'
- GO_SDK_VERSION='${{ needs.plan.outputs.go_sdk_version }}'
EXISTING_TAGS=()
NEW_TAGS=()
@@ -467,17 +456,11 @@ jobs:
continue
fi
- # Extract version
- GO_FLAG=""
- if [ "$KEY" = "sdk-go" ] && [ -n "$GO_SDK_VERSION" ]; then
- GO_FLAG="--go-sdk-version $GO_SDK_VERSION"
- fi
-
# Make script executable if needed
chmod +x scripts/extract-version.sh || true
- VERSION=$(scripts/extract-version.sh "$KEY" $GO_FLAG 2>/dev/null
|| echo "ERROR")
- TAG=$(scripts/extract-version.sh "$KEY" $GO_FLAG --tag 2>/dev/null
|| echo "ERROR")
+ VERSION=$(scripts/extract-version.sh "$KEY" 2>/dev/null || echo
"ERROR")
+ TAG=$(scripts/extract-version.sh "$KEY" --tag 2>/dev/null || echo
"ERROR")
if [ "$VERSION" = "ERROR" ] || [ "$TAG" = "ERROR" ]; then
echo "❌ Failed to extract version/tag for $NAME"
@@ -881,14 +864,10 @@ jobs:
shell: bash
run: |
set -euo pipefail
- GO_FLAG=""
- if [ "${{ matrix.key }}" = "sdk-go" ] && [ -n "${{
needs.plan.outputs.go_sdk_version }}" ]; then
- GO_FLAG="--go-sdk-version ${{ needs.plan.outputs.go_sdk_version }}"
- fi
- VERSION=$(scripts/extract-version.sh "${{ matrix.key }}" $GO_FLAG)
+ VERSION=$(scripts/extract-version.sh "${{ matrix.key }}")
# If a tag pattern exists for this component, ask the script for a
tag as well
if [ -n "${{ matrix.tag_pattern }}" ] && [ "${{ matrix.tag_pattern
}}" != "null" ]; then
- TAG=$(scripts/extract-version.sh "${{ matrix.key }}" $GO_FLAG
--tag)
+ TAG=$(scripts/extract-version.sh "${{ matrix.key }}" --tag)
else
TAG=""
fi
@@ -1016,7 +995,6 @@ jobs:
run: |
set -euo pipefail
TARGETS_JSON='${{ needs.plan.outputs.targets }}'
- GO_SDK_VERSION='${{ needs.plan.outputs.go_sdk_version }}'
CREATE_EDGE_DOCKER_TAG="${{ inputs.create_edge_docker_tag }}"
echo "$TARGETS_JSON" | jq -r '.include[] | select(.key!="noop") |
@base64' | while read -r row; do
@@ -1032,13 +1010,8 @@ jobs:
continue
fi
- GO_FLAG=""
- if [ "$KEY" = "sdk-go" ] && [ -n "$GO_SDK_VERSION" ]; then
- GO_FLAG="--go-sdk-version $GO_SDK_VERSION"
- fi
-
- VERSION=$(scripts/extract-version.sh "$KEY" $GO_FLAG)
- TAG=$(scripts/extract-version.sh "$KEY" $GO_FLAG --tag)
+ VERSION=$(scripts/extract-version.sh "$KEY")
+ TAG=$(scripts/extract-version.sh "$KEY" --tag)
# In auto-publish mode (create_edge_docker_tag=true), skip Docker
components
# with stable versions - only pre-release versions should get
versioned tags.
@@ -1134,7 +1107,6 @@ jobs:
# Parse the targets from plan job
TARGETS_JSON='${{ needs.plan.outputs.targets }}'
- GO_SDK_VERSION='${{ needs.plan.outputs.go_sdk_version }}'
echo "$TARGETS_JSON" | jq -r '.include[] | select(.key!="noop") |
@base64' | while read -r row; do
_jq() { echo "$row" | base64 -d | jq -r "$1"; }
@@ -1144,18 +1116,12 @@ jobs:
REGISTRY=$(_jq '.registry')
TAG_PATTERN=$(_jq '.tag_pattern')
- # Extract version using the script
- GO_FLAG=""
- if [ "$KEY" = "sdk-go" ] && [ -n "$GO_SDK_VERSION" ]; then
- GO_FLAG="--go-sdk-version $GO_SDK_VERSION"
- fi
-
- VERSION=$(scripts/extract-version.sh "$KEY" $GO_FLAG 2>/dev/null
|| echo "N/A")
+ VERSION=$(scripts/extract-version.sh "$KEY" 2>/dev/null || echo
"N/A")
# Get tag if pattern exists
TAG=""
if [ -n "$TAG_PATTERN" ] && [ "$TAG_PATTERN" != "null" ]; then
- TAG=$(scripts/extract-version.sh "$KEY" $GO_FLAG --tag
2>/dev/null || echo "N/A")
+ TAG=$(scripts/extract-version.sh "$KEY" --tag 2>/dev/null ||
echo "N/A")
else
TAG="N/A"
fi
diff --git a/foreign/go/contracts/version.go b/foreign/go/contracts/version.go
new file mode 100644
index 000000000..84452ee25
--- /dev/null
+++ b/foreign/go/contracts/version.go
@@ -0,0 +1,22 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package iggcon
+
+// TODO: Wire Version into binary_serialization/log_in_request_serializer.go
+// to send the actual SDK version during login instead of an empty string.
+const Version = "0.6.1-edge.1"
diff --git a/scripts/extract-version.sh b/scripts/extract-version.sh
index 46d5d2da7..30a66d09a 100755
--- a/scripts/extract-version.sh
+++ b/scripts/extract-version.sh
@@ -23,7 +23,7 @@
# versions from Cargo.toml, package.json, pyproject.toml, and other formats.
#
# Usage:
-# ./extract-version.sh <component> [--tag] [--go-sdk-version <version>]
+# ./extract-version.sh <component> [--tag]
#
# Examples:
# # Get version for Rust SDK
@@ -38,8 +38,8 @@
# # Get tag for Node SDK
# ./extract-version.sh sdk-node --tag # Output: node-sdk-0.5.0
#
-# # Get version for Go SDK (requires explicit version)
-# ./extract-version.sh sdk-go --go-sdk-version 1.2.3 # Output: 1.2.3
+# # Get version for Go SDK
+# ./extract-version.sh sdk-go # Output: 0.6.1-edge.1
#
# The script uses the configuration from .github/config/publish.yml to
determine:
# - Where to find the version file (version_file)
@@ -62,7 +62,6 @@ CONFIG_FILE="$REPO_ROOT/.github/config/publish.yml"
# Parse arguments
COMPONENT="${1:-}"
RETURN_TAG=false
-GO_SDK_VERSION=""
shift || true
while [[ $# -gt 0 ]]; do
@@ -71,10 +70,6 @@ while [[ $# -gt 0 ]]; do
RETURN_TAG=true
shift
;;
- --go-sdk-version)
- GO_SDK_VERSION="${2:-}"
- shift 2 || shift
- ;;
*)
echo "Unknown option: $1" >&2
exit 1
@@ -83,7 +78,7 @@ while [[ $# -gt 0 ]]; do
done
if [[ -z "$COMPONENT" ]]; then
- echo "Usage: $0 <component> [--tag] [--go-sdk-version <version>]" >&2
+ echo "Usage: $0 <component> [--tag]" >&2
echo "" >&2
echo "Available components:" >&2
yq eval '.components | keys | .[]' "$CONFIG_FILE" | sed 's/^/ - /' >&2
@@ -167,15 +162,8 @@ VERSION_FILE=$(get_config "version_file")
VERSION_REGEX=$(get_config "version_regex")
PACKAGE=$(get_config "package")
-# Special handling for Go SDK (version must be provided)
-if [[ "$COMPONENT" == "sdk-go" ]]; then
- VERSION="$GO_SDK_VERSION"
- if [[ -z "$VERSION" ]]; then
- echo "Error: Go version must be provided with --go-version flag" >&2
- exit 1
- fi
# For Rust components with cargo metadata support
-elif [[ "$COMPONENT" == rust-* ]] && [[ -n "$PACKAGE" ]]; then
+if [[ "$COMPONENT" == rust-* ]] && [[ -n "$PACKAGE" ]]; then
# Use package name from config if available
VERSION=$(extract_cargo_version "$PACKAGE" "$VERSION_FILE")
