This is an automated email from the ASF dual-hosted git repository. ptupitsyn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push: new 387c559fd5 IGNITE-21875 SQL API cleanup - remove properties and reactive methods (#3514) 387c559fd5 is described below commit 387c559fd5e67e4dbce3e4e157f744580e1b5aa6 Author: Pavel Tupitsyn <ptupit...@apache.org> AuthorDate: Fri Mar 29 15:45:11 2024 +0200 IGNITE-21875 SQL API cleanup - remove properties and reactive methods (#3514) * Statement properties are not used by the engine - remove * Reactive methods are not implemented - remove --- .../main/java/org/apache/ignite/sql/IgniteSql.java | 46 -------------- .../main/java/org/apache/ignite/sql/Statement.java | 28 --------- .../ignite/sql/reactive/ReactiveResultSet.java | 72 ---------------------- .../apache/ignite/sql/reactive/package-info.java | 22 ------- .../ignite/internal/client/sql/ClientSql.java | 38 ++---------- .../internal/client/sql/ClientStatement.java | 32 +--------- .../client/sql/ClientStatementBuilder.java | 23 +------ .../org/apache/ignite/client/ClientSqlTest.java | 8 --- .../client/ObservableTimestampPropagationTest.java | 1 - .../apache/ignite/client/ServerMetricsTest.java | 1 - .../ignite/internal/sql/api/IgniteSqlImpl.java | 26 -------- .../internal/sql/api/StatementBuilderImpl.java | 20 ------ .../ignite/internal/sql/api/StatementImpl.java | 7 --- 13 files changed, 6 insertions(+), 318 deletions(-) diff --git a/modules/api/src/main/java/org/apache/ignite/sql/IgniteSql.java b/modules/api/src/main/java/org/apache/ignite/sql/IgniteSql.java index 3d0f721ea8..7000090724 100644 --- a/modules/api/src/main/java/org/apache/ignite/sql/IgniteSql.java +++ b/modules/api/src/main/java/org/apache/ignite/sql/IgniteSql.java @@ -18,9 +18,7 @@ package org.apache.ignite.sql; import java.util.concurrent.CompletableFuture; -import java.util.concurrent.Flow; import org.apache.ignite.sql.async.AsyncResultSet; -import org.apache.ignite.sql.reactive.ReactiveResultSet; import org.apache.ignite.table.mapper.Mapper; import org.apache.ignite.tx.Transaction; import org.jetbrains.annotations.Nullable; @@ -155,28 +153,6 @@ public interface IgniteSql { Statement statement, @Nullable Object... arguments); - /** - * Executes SQL query in a reactive way. - * - * @param transaction Transaction to execute the query within or {@code null}. - * @param query SQL query template. - * @param arguments Arguments for the template (optional). - * @return Reactive result. - * @throws SqlException If failed. - */ - ReactiveResultSet executeReactive(@Nullable Transaction transaction, String query, @Nullable Object... arguments); - - /** - * Executes an SQL statement reactively. - * - * @param transaction Transaction to execute the statement within or {@code null}. - * @param statement SQL statement. - * @param arguments Arguments for the statement. - * @return Reactive result. - * @throws SqlException If failed. - */ - ReactiveResultSet executeReactive(@Nullable Transaction transaction, Statement statement, @Nullable Object... arguments); - /** * Executes a batched SQL query. Only DML queries are supported. * @@ -221,28 +197,6 @@ public interface IgniteSql { */ CompletableFuture<long[]> executeBatchAsync(@Nullable Transaction transaction, Statement statement, BatchedArguments batch); - /** - * Executes a batched SQL query reactively. - * - * @param transaction Transaction to execute the query within or {@code null}. - * @param query SQL query template. - * @param batch List of batch rows, where each row is a list of statement arguments. - * @return Publisher for the number of rows affected by the query. - * @throws SqlException If failed. - */ - Flow.Publisher<Long> executeBatchReactive(@Nullable Transaction transaction, String query, BatchedArguments batch); - - /** - * Executes a batched SQL statement reactively. - * - * @param transaction Transaction to execute the statement within or {@code null}. - * @param statement SQL statement to execute. - * @param batch List of batch rows, where each row is a list of statement arguments. - * @return Publisher for the number of rows affected by the query. - * @throws SqlException If failed. - */ - Flow.Publisher<Long> executeBatchReactive(@Nullable Transaction transaction, Statement statement, BatchedArguments batch); - /** * Executes a multi-statement SQL query. * diff --git a/modules/api/src/main/java/org/apache/ignite/sql/Statement.java b/modules/api/src/main/java/org/apache/ignite/sql/Statement.java index 3667707b50..e219f67605 100644 --- a/modules/api/src/main/java/org/apache/ignite/sql/Statement.java +++ b/modules/api/src/main/java/org/apache/ignite/sql/Statement.java @@ -19,7 +19,6 @@ package org.apache.ignite.sql; import java.time.ZoneId; import java.util.concurrent.TimeUnit; -import org.jetbrains.annotations.Nullable; /** * Object represents an SQL statement. @@ -67,14 +66,6 @@ public interface Statement extends AutoCloseable { */ ZoneId timeZoneId(); - /** - * Returns statement property value that overrides the session property value or {@code null} if session property value should be used. - * - * @param name Property name. - * @return Property value or {@code null} if not set. - */ - @Nullable Object property(String name); - /** * Creates a statement builder from the current statement. * @@ -160,25 +151,6 @@ public interface Statement extends AutoCloseable { */ StatementBuilder timeZoneId(ZoneId timeZoneId); - /** - * Returns a statement property value that overrides the session property value; returns {@code null} if the session - * property value should be used. - * - * @param name Property name. - * @return Property value or {@code null} if not set. - */ - @Nullable Object property(String name); - - /** - * Sets a statement property value that overrides the session property value. - * If {@code null} is passed, the session property value is used. - * - * @param name Property name. - * @param value Property value or {@code null} to use the value defined for the session. - * @return {@code this} for chaining. - */ - StatementBuilder property(String name, @Nullable Object value); - /** * Creates an SQL statement abject. * diff --git a/modules/api/src/main/java/org/apache/ignite/sql/reactive/ReactiveResultSet.java b/modules/api/src/main/java/org/apache/ignite/sql/reactive/ReactiveResultSet.java deleted file mode 100644 index e28a959989..0000000000 --- a/modules/api/src/main/java/org/apache/ignite/sql/reactive/ReactiveResultSet.java +++ /dev/null @@ -1,72 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.ignite.sql.reactive; - -import java.util.concurrent.Flow; -import org.apache.ignite.sql.ResultSet; -import org.apache.ignite.sql.ResultSetMetadata; -import org.apache.ignite.sql.SqlRow; -import org.jetbrains.annotations.Nullable; - -/** - * Provides methods to subscribe to query results in a reactive way. - * - * <p>Note: To be used with the reactive framework, such as ProjectReactor or R2DBC. - * - * @see ResultSet - */ -public interface ReactiveResultSet extends Flow.Publisher<SqlRow> { - /** - * Returns a publisher for the result metadata. - * - * @return Metadata publisher. - * @see ResultSet#metadata() - */ - Flow.Publisher<@Nullable ResultSetMetadata> metadata(); - - /** - * Returns a publisher for the flag that determines whether the query result is a collection of rows. - * - * <p>Note: {@code false} value means that the query is either conditional or an update. - * - * @return HasRowSet flag Publisher. - * @see ResultSet#hasRowSet() - */ - Flow.Publisher<Boolean> hasRowSet(); - - /** - * Returns the number of rows affected by the DML statement execution (such as "INSERT", "UPDATE", etc.). - * Returns {@code 0} if the statement returns nothing (such as "ALTER TABLE", etc.) or {@code -1} if not applicable. - * - * <p>Note: If the method returns {@code -1}, either {@link #hasRowSet()} or {@link #wasApplied()} returns {@code true}. - * - * @return Number of rows. - * @see ResultSet#affectedRows() - */ - Flow.Publisher<Long> affectedRows(); - - /** - * Returns a publisher for the flag that determines whether the query that produces the result was conditional. - * - * <p>Note: {@code false} means the query either returned rows or was an update query. - * - * @return AppliedFlag Publisher. - * @see ResultSet#wasApplied() - */ - Flow.Publisher<Boolean> wasApplied(); -} diff --git a/modules/api/src/main/java/org/apache/ignite/sql/reactive/package-info.java b/modules/api/src/main/java/org/apache/ignite/sql/reactive/package-info.java deleted file mode 100644 index 1f43d88a51..0000000000 --- a/modules/api/src/main/java/org/apache/ignite/sql/reactive/package-info.java +++ /dev/null @@ -1,22 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -/** - * SQL API for reactive SQL query execution. - */ - -package org.apache.ignite.sql.reactive; diff --git a/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java b/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java index cc7ebf9f2c..f4cd3c45c2 100644 --- a/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java +++ b/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java @@ -24,7 +24,6 @@ import java.util.Map.Entry; import java.util.Objects; import java.util.concurrent.CompletableFuture; import java.util.concurrent.CompletionException; -import java.util.concurrent.Flow.Publisher; import org.apache.ignite.internal.binarytuple.BinaryTupleBuilder; import org.apache.ignite.internal.client.PayloadOutputChannel; import org.apache.ignite.internal.client.PayloadReader; @@ -44,7 +43,6 @@ import org.apache.ignite.sql.SqlRow; import org.apache.ignite.sql.Statement; import org.apache.ignite.sql.Statement.StatementBuilder; import org.apache.ignite.sql.async.AsyncResultSet; -import org.apache.ignite.sql.reactive.ReactiveResultSet; import org.apache.ignite.table.mapper.Mapper; import org.apache.ignite.tx.Transaction; import org.apache.ignite.tx.TransactionException; @@ -76,7 +74,7 @@ public class ClientSql implements IgniteSql { /** {@inheritDoc} */ @Override public Statement createStatement(String query) { - return new ClientStatement(query, null, null, null, null); + return new ClientStatement(query, null, null, null); } /** {@inheritDoc} */ @@ -178,7 +176,7 @@ public class ClientSql implements IgniteSql { @Nullable Object... arguments) { Objects.requireNonNull(query); - ClientStatement statement = new ClientStatement(query, null, null, null, null); + ClientStatement statement = new ClientStatement(query, null, null, null); return executeAsync(transaction, statement, arguments); } @@ -201,7 +199,7 @@ public class ClientSql implements IgniteSql { @Nullable Object... arguments) { Objects.requireNonNull(query); - ClientStatement statement = new ClientStatement(query, null, null, null, null); + ClientStatement statement = new ClientStatement(query, null, null, null); return executeAsync(transaction, mapper, statement, arguments); } @@ -230,7 +228,7 @@ public class ClientSql implements IgniteSql { w.out().packLongNullable(0L); // defaultSessionTimeout - packProperties(w, clientStatement.properties()); + packProperties(w, null); w.out().packString(clientStatement.query()); @@ -253,20 +251,6 @@ public class ClientSql implements IgniteSql { return ch.serviceAsync(ClientOp.SQL_EXEC, payloadWriter, payloadReader); } - /** {@inheritDoc} */ - @Override - public ReactiveResultSet executeReactive(@Nullable Transaction transaction, String query, @Nullable Object... arguments) { - // TODO IGNITE-17058. - throw new UnsupportedOperationException("Not implemented yet."); - } - - /** {@inheritDoc} */ - @Override - public ReactiveResultSet executeReactive(@Nullable Transaction transaction, Statement statement, @Nullable Object... arguments) { - // TODO IGNITE-17058. - throw new UnsupportedOperationException("Not implemented yet."); - } - /** {@inheritDoc} */ @Override public CompletableFuture<long[]> executeBatchAsync(@Nullable Transaction transaction, String query, BatchedArguments batch) { @@ -281,20 +265,6 @@ public class ClientSql implements IgniteSql { throw new UnsupportedOperationException("Not implemented yet."); } - /** {@inheritDoc} */ - @Override - public Publisher<Long> executeBatchReactive(@Nullable Transaction transaction, String query, BatchedArguments batch) { - // TODO IGNITE-17058. - throw new UnsupportedOperationException("Not implemented yet."); - } - - /** {@inheritDoc} */ - @Override - public Publisher<Long> executeBatchReactive(@Nullable Transaction transaction, Statement statement, BatchedArguments batch) { - // TODO IGNITE-17058. - throw new UnsupportedOperationException("Not implemented yet."); - } - /** {@inheritDoc} */ @Override public CompletableFuture<Void> executeScriptAsync(String query, @Nullable Object... arguments) { diff --git a/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientStatement.java b/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientStatement.java index a1f024d070..42256f572b 100644 --- a/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientStatement.java +++ b/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientStatement.java @@ -19,11 +19,9 @@ package org.apache.ignite.internal.client.sql; import java.time.ZoneId; import java.time.ZoneOffset; -import java.util.Map; import java.util.Objects; import java.util.concurrent.TimeUnit; import org.apache.ignite.sql.Statement; -import org.jetbrains.annotations.Nullable; /** * Client SQL statement. @@ -41,9 +39,6 @@ public class ClientStatement implements Statement { /** Page size. */ private final Integer pageSize; - /** Properties. */ - private final Map<String, Object> properties; - /** * Constructor. * @@ -51,22 +46,19 @@ public class ClientStatement implements Statement { * @param defaultSchema Default schema. * @param queryTimeoutMs Timeout * @param pageSize Page size. - * @param properties Properties. */ @SuppressWarnings("AssignmentOrReturnOfFieldWithMutableType") public ClientStatement( String query, String defaultSchema, Long queryTimeoutMs, - Integer pageSize, - Map<String, Object> properties) { + Integer pageSize) { Objects.requireNonNull(query); this.query = query; this.defaultSchema = defaultSchema; this.queryTimeoutMs = queryTimeoutMs; this.pageSize = pageSize; - this.properties = properties; } /** {@inheritDoc} */ @@ -120,22 +112,6 @@ public class ClientStatement implements Statement { return pageSize; } - /** {@inheritDoc} */ - @Override - public @Nullable Object property(String name) { - return properties == null ? null : properties.get(name); - } - - /** - * Gets the properties map. - * - * @return Properties. - */ - @SuppressWarnings("AssignmentOrReturnOfFieldWithMutableType") - public Map<String, Object> properties() { - return properties; - } - /** {@inheritDoc} */ @Override public StatementBuilder toBuilder() { @@ -151,12 +127,6 @@ public class ClientStatement implements Statement { builder.queryTimeout(queryTimeoutMs, TimeUnit.MILLISECONDS); } - if (properties != null) { - for (var entry : properties.entrySet()) { - builder.property(entry.getKey(), entry.getValue()); - } - } - return builder; } diff --git a/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientStatementBuilder.java b/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientStatementBuilder.java index 5f9d172bb8..d7807cbc3c 100644 --- a/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientStatementBuilder.java +++ b/modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientStatementBuilder.java @@ -18,21 +18,15 @@ package org.apache.ignite.internal.client.sql; import java.time.ZoneId; -import java.util.HashMap; -import java.util.Map; import java.util.Objects; import java.util.concurrent.TimeUnit; import org.apache.ignite.sql.Statement; import org.apache.ignite.sql.Statement.StatementBuilder; -import org.jetbrains.annotations.Nullable; /** * Client SQL statement builder. */ public class ClientStatementBuilder implements Statement.StatementBuilder { - /** Properties. */ - private final Map<String, Object> properties = new HashMap<>(); - /** Query. */ private String query; @@ -105,20 +99,6 @@ public class ClientStatementBuilder implements Statement.StatementBuilder { return this; } - /** {@inheritDoc} */ - @Override - public @Nullable Object property(String name) { - return properties.get(name); - } - - /** {@inheritDoc} */ - @Override - public StatementBuilder property(String name, @Nullable Object value) { - properties.put(name, value); - - return this; - } - @Override public ZoneId timeZoneId() { // TODO: https://issues.apache.org/jira/browse/IGNITE-21568 @@ -138,7 +118,6 @@ public class ClientStatementBuilder implements Statement.StatementBuilder { query, defaultSchema, queryTimeoutMs, - pageSize, - new HashMap<>(properties)); + pageSize); } } diff --git a/modules/client/src/test/java/org/apache/ignite/client/ClientSqlTest.java b/modules/client/src/test/java/org/apache/ignite/client/ClientSqlTest.java index d94c07e058..9f9a5f77af 100644 --- a/modules/client/src/test/java/org/apache/ignite/client/ClientSqlTest.java +++ b/modules/client/src/test/java/org/apache/ignite/client/ClientSqlTest.java @@ -21,7 +21,6 @@ import static org.junit.jupiter.api.Assertions.assertArrayEquals; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertNotNull; -import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertSame; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -85,8 +84,6 @@ public class ClientSqlTest extends AbstractClientTableTest { .defaultSchema("SCHEMA2") .queryTimeout(124, TimeUnit.SECONDS) .pageSize(235) - .property("prop2", "22") - .property("prop3", "3") .build(); AsyncResultSet<SqlRow> resultSet = client.sql().executeAsync(null, statement).join(); @@ -97,11 +94,6 @@ public class ClientSqlTest extends AbstractClientTableTest { assertEquals("SCHEMA2", props.get("schema")); assertEquals("124000", props.get("timeout")); assertEquals("235", props.get("pageSize")); - - // Properties are ignored by the SQL engine for now. - assertNull(props.get("prop1")); - assertNull(props.get("prop2")); - assertNull(props.get("prop3")); } @Test diff --git a/modules/client/src/test/java/org/apache/ignite/client/ObservableTimestampPropagationTest.java b/modules/client/src/test/java/org/apache/ignite/client/ObservableTimestampPropagationTest.java index 7950362d43..c873735c05 100644 --- a/modules/client/src/test/java/org/apache/ignite/client/ObservableTimestampPropagationTest.java +++ b/modules/client/src/test/java/org/apache/ignite/client/ObservableTimestampPropagationTest.java @@ -95,7 +95,6 @@ public class ObservableTimestampPropagationTest extends BaseIgniteAbstractTest { assertEquals(11, lastObservableTimestamp()); Statement statement = client.sql().statementBuilder() - .property("hasMorePages", true) .query("SELECT 1") .build(); diff --git a/modules/client/src/test/java/org/apache/ignite/client/ServerMetricsTest.java b/modules/client/src/test/java/org/apache/ignite/client/ServerMetricsTest.java index dac5499030..13808ba03f 100644 --- a/modules/client/src/test/java/org/apache/ignite/client/ServerMetricsTest.java +++ b/modules/client/src/test/java/org/apache/ignite/client/ServerMetricsTest.java @@ -71,7 +71,6 @@ public class ServerMetricsTest extends AbstractClientTest { @Test public void testSqlMetrics() { Statement statement = client.sql().statementBuilder() - .property("hasMorePages", true) .query("select 1") .build(); diff --git a/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/IgniteSqlImpl.java b/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/IgniteSqlImpl.java index 2490e7baec..b88c948ccf 100644 --- a/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/IgniteSqlImpl.java +++ b/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/IgniteSqlImpl.java @@ -33,7 +33,6 @@ import java.util.concurrent.CompletableFuture; import java.util.concurrent.CompletionException; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; -import java.util.concurrent.Flow.Publisher; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; import java.util.concurrent.atomic.AtomicBoolean; @@ -68,7 +67,6 @@ import org.apache.ignite.sql.SqlRow; import org.apache.ignite.sql.Statement; import org.apache.ignite.sql.Statement.StatementBuilder; import org.apache.ignite.sql.async.AsyncResultSet; -import org.apache.ignite.sql.reactive.ReactiveResultSet; import org.apache.ignite.table.mapper.Mapper; import org.apache.ignite.tx.IgniteTransactions; import org.apache.ignite.tx.Transaction; @@ -591,30 +589,6 @@ public class IgniteSqlImpl implements IgniteSql, IgniteComponent { }); } - /** {@inheritDoc} */ - @Override - public ReactiveResultSet executeReactive(@Nullable Transaction transaction, String query, @Nullable Object... arguments) { - throw new UnsupportedOperationException("Not implemented yet."); - } - - /** {@inheritDoc} */ - @Override - public ReactiveResultSet executeReactive(@Nullable Transaction transaction, Statement statement, @Nullable Object... arguments) { - throw new UnsupportedOperationException("Not implemented yet."); - } - - /** {@inheritDoc} */ - @Override - public Publisher<Long> executeBatchReactive(@Nullable Transaction transaction, String query, BatchedArguments batch) { - throw new UnsupportedOperationException("Not implemented yet."); - } - - /** {@inheritDoc} */ - @Override - public Publisher<Long> executeBatchReactive(@Nullable Transaction transaction, Statement statement, BatchedArguments batch) { - throw new UnsupportedOperationException("Not implemented yet."); - } - private static void validateDmlResult(AsyncCursor.BatchedResult<InternalSqlRow> page) { if (page == null || page.items() == null diff --git a/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/StatementBuilderImpl.java b/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/StatementBuilderImpl.java index 01f056ee4f..b6ceccc30a 100644 --- a/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/StatementBuilderImpl.java +++ b/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/StatementBuilderImpl.java @@ -19,21 +19,15 @@ package org.apache.ignite.internal.sql.api; import java.time.ZoneId; import java.time.ZoneOffset; -import java.util.HashMap; -import java.util.Map; import java.util.Objects; import java.util.concurrent.TimeUnit; import org.apache.ignite.sql.Statement; import org.apache.ignite.sql.Statement.StatementBuilder; -import org.jetbrains.annotations.Nullable; /** * Statement builder. */ class StatementBuilderImpl implements StatementBuilder { - /** Properties. */ - private final Map<String, Object> properties = new HashMap<>(); - /** Query. */ private String query; @@ -123,20 +117,6 @@ class StatementBuilderImpl implements StatementBuilder { return this; } - /** {@inheritDoc} */ - @Override - public @Nullable Object property(String name) { - return properties.get(name); - } - - /** {@inheritDoc} */ - @Override - public StatementBuilder property(String name, @Nullable Object value) { - properties.put(name, value); - - return this; - } - /** {@inheritDoc} */ @Override public Statement build() { diff --git a/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/StatementImpl.java b/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/StatementImpl.java index d708a401f3..cdae5bc772 100644 --- a/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/StatementImpl.java +++ b/modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/StatementImpl.java @@ -20,7 +20,6 @@ package org.apache.ignite.internal.sql.api; import java.time.ZoneId; import java.util.concurrent.TimeUnit; import org.apache.ignite.sql.Statement; -import org.jetbrains.annotations.Nullable; /** * Statement. @@ -69,12 +68,6 @@ class StatementImpl implements Statement { throw new UnsupportedOperationException("Not implemented yet."); } - /** {@inheritDoc} */ - @Override - public @Nullable Object property(String name) { - throw new UnsupportedOperationException("Not implemented yet."); - } - /** {@inheritDoc} */ @Override public StatementBuilder toBuilder() {