This is an automated email from the ASF dual-hosted git repository.
timoninmaxim pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git
The following commit(s) were added to refs/heads/master by this push:
new 35736e63fa9 IGNITE-25946 Use MessageSerializer for
UserAuthenticateRequestMessage (#12197)
35736e63fa9 is described below
commit 35736e63fa9ab724cfdba46369b16927311215b1
Author: Dmitry Werner <[email protected]>
AuthorDate: Sun Jul 20 00:33:20 2025 +0500
IGNITE-25946 Use MessageSerializer for UserAuthenticateRequestMessage
(#12197)
---
.../communication/GridIoMessageFactory.java | 3 +-
.../UserAuthenticateRequestMessage.java | 93 ++++++----------------
2 files changed, 25 insertions(+), 71 deletions(-)
diff --git
a/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
b/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
index 71d8e5a411a..ceb6387738c 100644
---
a/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
+++
b/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
@@ -30,6 +30,7 @@ import
org.apache.ignite.internal.codegen.GridCacheEntryInfoSerializer;
import org.apache.ignite.internal.codegen.GridIntListSerializer;
import org.apache.ignite.internal.codegen.GridJobCancelRequestSerializer;
import org.apache.ignite.internal.codegen.SessionChannelMessageSerializer;
+import
org.apache.ignite.internal.codegen.UserAuthenticateRequestMessageSerializer;
import org.apache.ignite.internal.managers.checkpoint.GridCheckpointRequest;
import org.apache.ignite.internal.managers.deployment.GridDeploymentInfoBean;
import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
@@ -311,7 +312,7 @@ public class GridIoMessageFactory implements
MessageFactoryProvider {
factory.register((short)128, CacheGroupAffinityMessage::new);
factory.register((short)129, WalStateAckMessage::new);
factory.register((short)130,
UserManagementOperationFinishedMessage::new);
- factory.register((short)131, UserAuthenticateRequestMessage::new);
+ factory.register((short)131, UserAuthenticateRequestMessage::new, new
UserAuthenticateRequestMessageSerializer());
factory.register((short)132, UserAuthenticateResponseMessage::new);
factory.register((short)133, ClusterMetricsUpdateMessage::new);
factory.register((short)134, ContinuousRoutineStartResultMessage::new);
diff --git
a/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/UserAuthenticateRequestMessage.java
b/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/UserAuthenticateRequestMessage.java
index bb9f411af66..2b1347eb189 100644
---
a/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/UserAuthenticateRequestMessage.java
+++
b/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/UserAuthenticateRequestMessage.java
@@ -17,24 +17,25 @@
package org.apache.ignite.internal.processors.authentication;
-import java.nio.ByteBuffer;
+import org.apache.ignite.internal.Order;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.apache.ignite.lang.IgniteUuid;
import org.apache.ignite.plugin.extensions.communication.Message;
-import org.apache.ignite.plugin.extensions.communication.MessageReader;
-import org.apache.ignite.plugin.extensions.communication.MessageWriter;
/**
* Message is sent from client to coordinator node when a user needs to
authorize on client node.
*/
public class UserAuthenticateRequestMessage implements Message {
/** User name. */
+ @Order(0)
private String name;
/** User password. */
+ @Order(value = 1, method = "password")
private String passwd;
/** Request ID. */
+ @Order(2)
private IgniteUuid id = IgniteUuid.randomUuid();
/**
@@ -60,6 +61,13 @@ public class UserAuthenticateRequestMessage implements
Message {
return name;
}
+ /**
+ * @param name New username.
+ */
+ public void name(String name) {
+ this.name = name;
+ }
+
/**
* @return User password.
*/
@@ -67,6 +75,13 @@ public class UserAuthenticateRequestMessage implements
Message {
return passwd;
}
+ /**
+ * @param passwd New user password.
+ */
+ public void password(String passwd) {
+ this.passwd = passwd;
+ }
+
/**
* @return Request ID.
*/
@@ -74,73 +89,11 @@ public class UserAuthenticateRequestMessage implements
Message {
return id;
}
- /** {@inheritDoc} */
- @Override public boolean writeTo(ByteBuffer buf, MessageWriter writer) {
- writer.setBuffer(buf);
-
- if (!writer.isHeaderWritten()) {
- if (!writer.writeHeader(directType()))
- return false;
-
- writer.onHeaderWritten();
- }
-
- switch (writer.state()) {
- case 0:
- if (!writer.writeIgniteUuid(id))
- return false;
-
- writer.incrementState();
-
- case 1:
- if (!writer.writeString(name))
- return false;
-
- writer.incrementState();
-
- case 2:
- if (!writer.writeString(passwd))
- return false;
-
- writer.incrementState();
-
- }
-
- return true;
- }
-
- /** {@inheritDoc} */
- @Override public boolean readFrom(ByteBuffer buf, MessageReader reader) {
- reader.setBuffer(buf);
-
- switch (reader.state()) {
- case 0:
- id = reader.readIgniteUuid();
-
- if (!reader.isLastRead())
- return false;
-
- reader.incrementState();
-
- case 1:
- name = reader.readString();
-
- if (!reader.isLastRead())
- return false;
-
- reader.incrementState();
-
- case 2:
- passwd = reader.readString();
-
- if (!reader.isLastRead())
- return false;
-
- reader.incrementState();
-
- }
-
- return true;
+ /**
+ * @param id New request ID.
+ */
+ public void id(IgniteUuid id) {
+ this.id = id;
}
/** {@inheritDoc} */
