This is an automated email from the ASF dual-hosted git repository.
sergeychugunov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git
The following commit(s) were added to refs/heads/master by this push:
new 9f5c30e5fdc IGNITE-25960 Use MessageSerializer for
UserAuthenticateResponseMessage (#12199)
9f5c30e5fdc is described below
commit 9f5c30e5fdcc7db5da73e4e0e6d3d6f30ad2ad6e
Author: Dmitry Werner <[email protected]>
AuthorDate: Mon Jul 21 17:01:09 2025 +0500
IGNITE-25960 Use MessageSerializer for UserAuthenticateResponseMessage
(#12199)
---
.../communication/GridIoMessageFactory.java | 3 +-
.../UserAuthenticateResponseMessage.java | 71 +++++-----------------
2 files changed, 17 insertions(+), 57 deletions(-)
diff --git
a/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
b/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
index ceb6387738c..082bdf08567 100644
---
a/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
+++
b/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
@@ -31,6 +31,7 @@ import
org.apache.ignite.internal.codegen.GridIntListSerializer;
import org.apache.ignite.internal.codegen.GridJobCancelRequestSerializer;
import org.apache.ignite.internal.codegen.SessionChannelMessageSerializer;
import
org.apache.ignite.internal.codegen.UserAuthenticateRequestMessageSerializer;
+import
org.apache.ignite.internal.codegen.UserAuthenticateResponseMessageSerializer;
import org.apache.ignite.internal.managers.checkpoint.GridCheckpointRequest;
import org.apache.ignite.internal.managers.deployment.GridDeploymentInfoBean;
import org.apache.ignite.internal.managers.deployment.GridDeploymentRequest;
@@ -313,7 +314,7 @@ public class GridIoMessageFactory implements
MessageFactoryProvider {
factory.register((short)129, WalStateAckMessage::new);
factory.register((short)130,
UserManagementOperationFinishedMessage::new);
factory.register((short)131, UserAuthenticateRequestMessage::new, new
UserAuthenticateRequestMessageSerializer());
- factory.register((short)132, UserAuthenticateResponseMessage::new);
+ factory.register((short)132, UserAuthenticateResponseMessage::new, new
UserAuthenticateResponseMessageSerializer());
factory.register((short)133, ClusterMetricsUpdateMessage::new);
factory.register((short)134, ContinuousRoutineStartResultMessage::new);
factory.register((short)135, LatchAckMessage::new);
diff --git
a/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/UserAuthenticateResponseMessage.java
b/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/UserAuthenticateResponseMessage.java
index 2234c283ec3..f570005cc5f 100644
---
a/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/UserAuthenticateResponseMessage.java
+++
b/modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/UserAuthenticateResponseMessage.java
@@ -17,21 +17,21 @@
package org.apache.ignite.internal.processors.authentication;
-import java.nio.ByteBuffer;
+import org.apache.ignite.internal.Order;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.apache.ignite.lang.IgniteUuid;
import org.apache.ignite.plugin.extensions.communication.Message;
-import org.apache.ignite.plugin.extensions.communication.MessageReader;
-import org.apache.ignite.plugin.extensions.communication.MessageWriter;
/**
* Is sent from coordinator node to client to deliver the results of the user
authentication.
*/
public class UserAuthenticateResponseMessage implements Message {
/** Request ID. */
+ @Order(0)
private IgniteUuid id;
/** Error message. */
+ @Order(value = 1, method = "errorMessage")
private String errMsg;
/**
@@ -64,6 +64,13 @@ public class UserAuthenticateResponseMessage implements
Message {
return errMsg;
}
+ /**
+ * @param errMsg New error message.
+ */
+ public void errorMessage(String errMsg) {
+ this.errMsg = errMsg;
+ }
+
/**
* @return Request ID.
*/
@@ -71,59 +78,11 @@ public class UserAuthenticateResponseMessage implements
Message {
return id;
}
- /** {@inheritDoc} */
- @Override public boolean writeTo(ByteBuffer buf, MessageWriter writer) {
- writer.setBuffer(buf);
-
- if (!writer.isHeaderWritten()) {
- if (!writer.writeHeader(directType()))
- return false;
-
- writer.onHeaderWritten();
- }
-
- switch (writer.state()) {
- case 0:
- if (!writer.writeString(errMsg))
- return false;
-
- writer.incrementState();
-
- case 1:
- if (!writer.writeIgniteUuid(id))
- return false;
-
- writer.incrementState();
-
- }
-
- return true;
- }
-
- /** {@inheritDoc} */
- @Override public boolean readFrom(ByteBuffer buf, MessageReader reader) {
- reader.setBuffer(buf);
-
- switch (reader.state()) {
- case 0:
- errMsg = reader.readString();
-
- if (!reader.isLastRead())
- return false;
-
- reader.incrementState();
-
- case 1:
- id = reader.readIgniteUuid();
-
- if (!reader.isLastRead())
- return false;
-
- reader.incrementState();
-
- }
-
- return true;
+ /**
+ * @param id New request ID.
+ */
+ public void id(IgniteUuid id) {
+ this.id = id;
}
/** {@inheritDoc} */
