This is an automated email from the ASF dual-hosted git repository.
ibessonov pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 63c2e4c489d IGNITE-25955 Change error name/code used in case of a
server socket BindException (#6322)
63c2e4c489d is described below
commit 63c2e4c489d840347c8e1f1608969be4b9466708
Author: Aditya Mukhopadhyay <[email protected]>
AuthorDate: Fri Jul 25 19:23:00 2025 +0530
IGNITE-25955 Change error name/code used in case of a server socket
BindException (#6322)
---
modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java | 8 ++++++--
.../org/apache/ignite/client/handler/ClientHandlerModule.java | 4 ++--
.../org/apache/ignite/internal/network/netty/NettyServer.java | 4 ++--
modules/platforms/cpp/ignite/common/error_codes.h | 3 ++-
modules/platforms/cpp/ignite/odbc/common_types.cpp | 2 +-
modules/platforms/dotnet/Apache.Ignite/ErrorCodes.g.cs | 8 ++++++--
6 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java
b/modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java
index a91aa0f6129..e259b65e281 100755
--- a/modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java
+++ b/modules/api/src/main/java/org/apache/ignite/lang/ErrorGroups.java
@@ -515,8 +515,8 @@ public class ErrorGroups {
/** Unresolvable consistent ID. */
public static final int UNRESOLVABLE_CONSISTENT_ID_ERR =
NETWORK_ERR_GROUP.registerErrorCode((short) 1);
- /** Port is in use. */
- public static final int PORT_IN_USE_ERR =
NETWORK_ERR_GROUP.registerErrorCode((short) 2);
+ /** Address or port bind error. */
+ public static final int BIND_ERR =
NETWORK_ERR_GROUP.registerErrorCode((short) 2);
/** File transfer error. */
public static final int FILE_TRANSFER_ERR =
NETWORK_ERR_GROUP.registerErrorCode((short) 3);
@@ -529,6 +529,10 @@ public class ErrorGroups {
/** Could not resolve address. */
public static final int ADDRESS_UNRESOLVED_ERR =
NETWORK_ERR_GROUP.registerErrorCode((short) 6);
+
+ /** Alias for BIND_ERROR. This was the old name, now deprecated. */
+ @Deprecated
+ public static final int PORT_IN_USE_ERR = BIND_ERR;
}
/** Node configuration error group. */
diff --git
a/modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java
b/modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java
index bbd890c4274..52d5f292868 100644
---
a/modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java
+++
b/modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java
@@ -21,7 +21,7 @@ import static
java.util.concurrent.CompletableFuture.failedFuture;
import static
org.apache.ignite.internal.util.CompletableFutures.nullCompletedFuture;
import static org.apache.ignite.lang.ErrorGroups.Common.INTERNAL_ERR;
import static
org.apache.ignite.lang.ErrorGroups.Network.ADDRESS_UNRESOLVED_ERR;
-import static org.apache.ignite.lang.ErrorGroups.Network.PORT_IN_USE_ERR;
+import static org.apache.ignite.lang.ErrorGroups.Network.BIND_ERR;
import io.netty.bootstrap.ServerBootstrap;
import io.netty.channel.Channel;
@@ -399,7 +399,7 @@ public class ClientHandlerModule implements
IgniteComponent, PlatformComputeTran
String address = addresses.length == 0 ? "" : addresses[0];
result.completeExceptionally(
new IgniteException(
- PORT_IN_USE_ERR,
+ BIND_ERR,
"Cannot start thin client connector endpoint
at address=" + address + ", port=" + port,
bindFut.cause())
);
diff --git
a/modules/network/src/main/java/org/apache/ignite/internal/network/netty/NettyServer.java
b/modules/network/src/main/java/org/apache/ignite/internal/network/netty/NettyServer.java
index f36f62f68b4..17013239321 100644
---
a/modules/network/src/main/java/org/apache/ignite/internal/network/netty/NettyServer.java
+++
b/modules/network/src/main/java/org/apache/ignite/internal/network/netty/NettyServer.java
@@ -19,7 +19,7 @@ package org.apache.ignite.internal.network.netty;
import static
org.apache.ignite.internal.util.CompletableFutures.nullCompletedFuture;
import static org.apache.ignite.lang.ErrorGroups.Common.INTERNAL_ERR;
-import static org.apache.ignite.lang.ErrorGroups.Network.PORT_IN_USE_ERR;
+import static org.apache.ignite.lang.ErrorGroups.Network.BIND_ERR;
import io.netty.bootstrap.ServerBootstrap;
import io.netty.channel.Channel;
@@ -171,7 +171,7 @@ public class NettyServer {
} else {
String address = addresses.length == 0 ? "" : addresses[0];
String errorMessage = "Cannot start server at address=" +
address + ", port=" + port;
- bindFuture.completeExceptionally(new
IgniteException(PORT_IN_USE_ERR, errorMessage, future.cause()));
+ bindFuture.completeExceptionally(new
IgniteException(BIND_ERR, errorMessage, future.cause()));
}
});
diff --git a/modules/platforms/cpp/ignite/common/error_codes.h
b/modules/platforms/cpp/ignite/common/error_codes.h
index c82c51248a0..08f4078ec5b 100644
--- a/modules/platforms/cpp/ignite/common/error_codes.h
+++ b/modules/platforms/cpp/ignite/common/error_codes.h
@@ -156,11 +156,12 @@ enum class code : underlying_t {
// Network group. Group code: 11
UNRESOLVABLE_CONSISTENT_ID = 0xb0001,
- PORT_IN_USE = 0xb0002,
+ BIND = 0xb0002,
FILE_TRANSFER = 0xb0003,
FILE_VALIDATION = 0xb0004,
RECIPIENT_LEFT = 0xb0005,
ADDRESS_UNRESOLVED = 0xb0006,
+ PORT_IN_USE [[deprecated("PORT_IN_USE is deprecated. Use BIND instead.")]]
= BIND,
// NodeConfiguration group. Group code: 12
CONFIG_READ = 0xc0001,
diff --git a/modules/platforms/cpp/ignite/odbc/common_types.cpp
b/modules/platforms/cpp/ignite/odbc/common_types.cpp
index 9c02d135c12..f6b09fb07e6 100644
--- a/modules/platforms/cpp/ignite/odbc/common_types.cpp
+++ b/modules/platforms/cpp/ignite/odbc/common_types.cpp
@@ -232,7 +232,7 @@ sql_state error_code_to_sql_state(error::code code) {
// Network group. Group code: 11
case error::code::UNRESOLVABLE_CONSISTENT_ID:
- case error::code::PORT_IN_USE:
+ case error::code::BIND:
case error::code::FILE_TRANSFER:
case error::code::FILE_VALIDATION:
case error::code::RECIPIENT_LEFT:
diff --git a/modules/platforms/dotnet/Apache.Ignite/ErrorCodes.g.cs
b/modules/platforms/dotnet/Apache.Ignite/ErrorCodes.g.cs
index 0ae1a8571f4..77c80bc7e7c 100644
--- a/modules/platforms/dotnet/Apache.Ignite/ErrorCodes.g.cs
+++ b/modules/platforms/dotnet/Apache.Ignite/ErrorCodes.g.cs
@@ -450,8 +450,8 @@ namespace Apache.Ignite
/// <summary> UnresolvableConsistentId error. </summary>
public const int UnresolvableConsistentId = (GroupCode << 16) | (1
& 0xFFFF);
- /// <summary> PortInUse error. </summary>
- public const int PortInUse = (GroupCode << 16) | (2 & 0xFFFF);
+ /// <summary> Bind error. </summary>
+ public const int Bind = (GroupCode << 16) | (2 & 0xFFFF);
/// <summary> FileTransfer error. </summary>
public const int FileTransfer = (GroupCode << 16) | (3 & 0xFFFF);
@@ -464,6 +464,10 @@ namespace Apache.Ignite
/// <summary> AddressUnresolved error. </summary>
public const int AddressUnresolved = (GroupCode << 16) | (6 &
0xFFFF);
+
+ /// <summary> PortInUse is obsolete. Use Bind instead. </summary>
+ [Obsolete]
+ public const int PortInUse = Bind;
}
/// <summary> NodeConfiguration errors. </summary>
