This is an automated email from the ASF dual-hosted git repository.
sergeychugunov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git
The following commit(s) were added to refs/heads/master by this push:
new 5784b72b451 IGNITE-26045 Use MessageSerializer for
TcpInverseConnectionResponseMessage (#12226)
5784b72b451 is described below
commit 5784b72b451de9036e01560f8fcf99cdf014022b
Author: Dmitry Werner <[email protected]>
AuthorDate: Wed Jul 30 19:50:34 2025 +0500
IGNITE-26045 Use MessageSerializer for TcpInverseConnectionResponseMessage
(#12226)
---
.../communication/GridIoMessageFactory.java | 3 +-
.../TcpInverseConnectionResponseMessage.java | 49 ++++------------------
2 files changed, 9 insertions(+), 43 deletions(-)
diff --git
a/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
b/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
index b7bf7f5ddc5..4b75909b2ac 100644
---
a/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
+++
b/modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java
@@ -37,6 +37,7 @@ import
org.apache.ignite.internal.codegen.GridQueryKillResponseSerializer;
import
org.apache.ignite.internal.codegen.MissingMappingRequestMessageSerializer;
import
org.apache.ignite.internal.codegen.MissingMappingResponseMessageSerializer;
import org.apache.ignite.internal.codegen.SessionChannelMessageSerializer;
+import
org.apache.ignite.internal.codegen.TcpInverseConnectionResponseMessageSerializer;
import
org.apache.ignite.internal.codegen.UserAuthenticateRequestMessageSerializer;
import
org.apache.ignite.internal.codegen.UserAuthenticateResponseMessageSerializer;
import
org.apache.ignite.internal.codegen.UserManagementOperationFinishedMessageSerializer;
@@ -339,7 +340,7 @@ public class GridIoMessageFactory implements
MessageFactoryProvider {
factory.register(GridIoSecurityAwareMessage.TYPE_CODE,
GridIoSecurityAwareMessage::new);
factory.register(SessionChannelMessage.TYPE_CODE,
SessionChannelMessage::new, new SessionChannelMessageSerializer());
factory.register(SingleNodeMessage.TYPE_CODE, SingleNodeMessage::new);
- factory.register((short)177, TcpInverseConnectionResponseMessage::new);
+ factory.register((short)177, TcpInverseConnectionResponseMessage::new,
new TcpInverseConnectionResponseMessageSerializer());
factory.register(SnapshotFilesRequestMessage.TYPE_CODE,
SnapshotFilesRequestMessage::new);
factory.register(SnapshotFilesFailureMessage.TYPE_CODE,
SnapshotFilesFailureMessage::new);
factory.register((short)180,
AtomicApplicationAttributesAwareRequest::new);
diff --git
a/modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/internal/TcpInverseConnectionResponseMessage.java
b/modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/internal/TcpInverseConnectionResponseMessage.java
index 5612956b9b1..aa90e5caacf 100644
---
a/modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/internal/TcpInverseConnectionResponseMessage.java
+++
b/modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/internal/TcpInverseConnectionResponseMessage.java
@@ -17,10 +17,8 @@
package org.apache.ignite.spi.communication.tcp.internal;
-import java.nio.ByteBuffer;
+import org.apache.ignite.internal.Order;
import org.apache.ignite.internal.util.typedef.internal.S;
-import org.apache.ignite.plugin.extensions.communication.MessageReader;
-import org.apache.ignite.plugin.extensions.communication.MessageWriter;
/**
* Inverse connection response message sent by client node as a response to
@@ -31,6 +29,7 @@ import
org.apache.ignite.plugin.extensions.communication.MessageWriter;
*/
public class TcpInverseConnectionResponseMessage implements
TcpConnectionIndexAwareMessage {
/** */
+ @Order(value = 0, method = "connectionIndex")
private int connIdx;
/** */
@@ -47,27 +46,11 @@ public class TcpInverseConnectionResponseMessage implements
TcpConnectionIndexAw
return connIdx;
}
- /** {@inheritDoc} */
- @Override public boolean writeTo(ByteBuffer buf, MessageWriter writer) {
- writer.setBuffer(buf);
-
- if (!writer.isHeaderWritten()) {
- if (!writer.writeHeader(directType()))
- return false;
-
- writer.onHeaderWritten();
- }
-
- switch (writer.state()) {
- case 0:
- if (!writer.writeInt(connIdx))
- return false;
-
- writer.incrementState();
-
- }
-
- return true;
+ /**
+ * @param connIdx New connection index.
+ */
+ public void connectionIndex(int connIdx) {
+ this.connIdx = connIdx;
}
/** {@inheritDoc} */
@@ -75,24 +58,6 @@ public class TcpInverseConnectionResponseMessage implements
TcpConnectionIndexAw
// No-op.
}
- /** {@inheritDoc} */
- @Override public boolean readFrom(ByteBuffer buf, MessageReader reader) {
- reader.setBuffer(buf);
-
- switch (reader.state()) {
- case 0:
- connIdx = reader.readInt();
-
- if (!reader.isLastRead())
- return false;
-
- reader.incrementState();
-
- }
-
- return true;
- }
-
/** {@inheritDoc} */
@Override public short directType() {
return 177;