This is an automated email from the ASF dual-hosted git repository.
ptupitsyn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 110b103448e IGNITE-27498 Improve sendServerExceptionStackTraceToClient
message (#7345)
110b103448e is described below
commit 110b103448e69ea417b0619354ae95b87bf20321
Author: Pavel Tupitsyn <[email protected]>
AuthorDate: Wed Jan 7 14:39:41 2026 +0200
IGNITE-27498 Improve sendServerExceptionStackTraceToClient message (#7345)
---
.../client/handler/ItClientHandlerMetricsTest.java | 2 +-
.../ignite/client/handler/ItClientHandlerTest.java | 19 +++++++++++++++----
.../client/handler/ClientInboundMessageHandler.java | 2 +-
.../runner/app/client/ItThinClientComputeTest.java | 8 ++++----
.../runner/app/client/ItThinClientConnectionTest.java | 3 ++-
5 files changed, 23 insertions(+), 11 deletions(-)
diff --git
a/modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerMetricsTest.java
b/modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerMetricsTest.java
index e413df4bc29..95ef46fdbfc 100644
---
a/modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerMetricsTest.java
+++
b/modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerMetricsTest.java
@@ -181,7 +181,7 @@ public class ItClientHandlerMetricsTest extends
BaseIgniteAbstractTest {
ItClientHandlerTestUtils.connectAndHandshake(serverModule, false,
true);
assertTrue(
- IgniteTestUtils.waitForCondition(() ->
testServer.metrics().bytesSent() == 304, 1000),
+ IgniteTestUtils.waitForCondition(() ->
testServer.metrics().bytesSent() == 319, 1000),
() -> "bytesSent: " + testServer.metrics().bytesSent());
assertTrue(
diff --git
a/modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerTest.java
b/modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerTest.java
index aa2ffde0585..91c19c741e6 100644
---
a/modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerTest.java
+++
b/modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerTest.java
@@ -227,7 +227,10 @@ public class ItClientHandlerTest extends
BaseIgniteAbstractTest {
"org.apache.ignite.security.exception.UnsupportedAuthenticationTypeException",
errClassName
);
- assertEquals("To see the full stack trace set
clientConnector.sendServerExceptionStackTraceToClient:true", errStackTrace);
+
+ assertEquals(
+ "To see the full stack trace, set
clientConnector.sendServerExceptionStackTraceToClient:true on the server",
+ errStackTrace);
}
}
@@ -353,7 +356,9 @@ public class ItClientHandlerTest extends
BaseIgniteAbstractTest {
assertThat(errMsg, containsString("Authentication failed"));
assertEquals("org.apache.ignite.security.exception.InvalidCredentialsException",
errClassName);
- assertEquals("To see the full stack trace set
clientConnector.sendServerExceptionStackTraceToClient:true", errStackTrace);
+ assertEquals(
+ "To see the full stack trace, set
clientConnector.sendServerExceptionStackTraceToClient:true on the server",
+ errStackTrace);
}
}
@@ -408,7 +413,10 @@ public class ItClientHandlerTest extends
BaseIgniteAbstractTest {
assertThat(errMsg, containsString("Authentication failed"));
assertEquals("org.apache.ignite.security.exception.InvalidCredentialsException",
errClassName);
- assertEquals("To see the full stack trace set
clientConnector.sendServerExceptionStackTraceToClient:true", errStackTrace);
+
+ assertEquals(
+ "To see the full stack trace, set
clientConnector.sendServerExceptionStackTraceToClient:true on the server",
+ errStackTrace);
}
}
@@ -461,7 +469,10 @@ public class ItClientHandlerTest extends
BaseIgniteAbstractTest {
assertThat(errMsg, containsString("Unsupported version: 2.8.0"));
assertEquals("org.apache.ignite.lang.IgniteException",
errClassName);
- assertEquals("To see the full stack trace set
clientConnector.sendServerExceptionStackTraceToClient:true", errStackTrace);
+
+ assertEquals(
+ "To see the full stack trace, set
clientConnector.sendServerExceptionStackTraceToClient:true on the server",
+ errStackTrace);
}
}
diff --git
a/modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java
b/modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java
index 19e3f0c464c..129bbe60ffe 100644
---
a/modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java
+++
b/modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java
@@ -727,7 +727,7 @@ public class ClientInboundMessageHandler
if (configuration.sendServerExceptionStackTraceToClient()) {
packer.packString(ExceptionUtils.getFullStackTrace(pubErr));
} else {
- packer.packString("To see the full stack trace set
clientConnector.sendServerExceptionStackTraceToClient:true");
+ packer.packString("To see the full stack trace, set
clientConnector.sendServerExceptionStackTraceToClient:true on the server");
}
// Extensions.
diff --git
a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientComputeTest.java
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientComputeTest.java
index c051269e806..1a7306454c9 100644
---
a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientComputeTest.java
+++
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientComputeTest.java
@@ -440,7 +440,7 @@ public class ItThinClientComputeTest extends
ItAbstractThinClientTest {
assertNotNull(cause.getCause());
String hint = cause.getCause().getMessage();
- assertEquals("To see the full stack trace set
clientConnector.sendServerExceptionStackTraceToClient:true", hint);
+ assertEquals("To see the full stack trace, set
clientConnector.sendServerExceptionStackTraceToClient:true on the server",
hint);
}
@Test
@@ -456,7 +456,7 @@ public class ItThinClientComputeTest extends
ItAbstractThinClientTest {
assertNotNull(cause.getCause());
String hint = cause.getCause().getMessage();
- assertEquals("To see the full stack trace set
clientConnector.sendServerExceptionStackTraceToClient:true", hint);
+ assertEquals("To see the full stack trace, set
clientConnector.sendServerExceptionStackTraceToClient:true on the server",
hint);
}
@ParameterizedTest
@@ -660,7 +660,7 @@ public class ItThinClientComputeTest extends
ItAbstractThinClientTest {
assertNotNull(cause.getCause());
String hint = cause.getCause().getMessage();
- assertEquals("To see the full stack trace set
clientConnector.sendServerExceptionStackTraceToClient:true", hint);
+ assertEquals("To see the full stack trace, set
clientConnector.sendServerExceptionStackTraceToClient:true on the server",
hint);
}
private static void assertComputeExceptionWithStackTrace(IgniteException
cause) {
@@ -892,7 +892,7 @@ public class ItThinClientComputeTest extends
ItAbstractThinClientTest {
assertNotNull(cause.getCause());
String hint = cause.getCause().getMessage();
- assertEquals("To see the full stack trace set
clientConnector.sendServerExceptionStackTraceToClient:true", hint);
+ assertEquals("To see the full stack trace, set
clientConnector.sendServerExceptionStackTraceToClient:true on the server",
hint);
}
}
diff --git
a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientConnectionTest.java
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientConnectionTest.java
index 20336aa3695..444f0489d3e 100644
---
a/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientConnectionTest.java
+++
b/modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientConnectionTest.java
@@ -133,7 +133,8 @@ public class ItThinClientConnectionTest extends
ItAbstractThinClientTest {
.collect(Collectors.toList());
assertThat(causes,
- hasItem(containsString("To see the full stack trace set
clientConnector.sendServerExceptionStackTraceToClient:true")));
+ hasItem(containsString("To see the full stack trace, "
+ + "set
clientConnector.sendServerExceptionStackTraceToClient:true on the server")));
}
@Test
