This is an automated email from the ASF dual-hosted git repository.
apkhmv pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
The following commit(s) were added to refs/heads/main by this push:
new 74c56e16b9b IGNITE-28496 remove pageAcquireTime metric due to perf
loss (#7963)
74c56e16b9b is described below
commit 74c56e16b9b231829b74e6f6661734c539e11db2
Author: Viacheslav Blinov <[email protected]>
AuthorDate: Fri Apr 10 15:34:29 2026 +0300
IGNITE-28496 remove pageAcquireTime metric due to perf loss (#7963)
---
.../persistence/PersistentPageMemory.java | 5 -----
.../PersistentPageMemoryMetricSource.java | 1 -
.../persistence/PersistentPageMemoryMetrics.java | 22 ----------------------
3 files changed, 28 deletions(-)
diff --git
a/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java
b/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java
index fc1df828f97..8f1cf4c39f8 100644
---
a/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java
+++
b/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java
@@ -603,8 +603,6 @@ public class PersistentPageMemory implements PageMemory {
grpId, hexLong(pageId)
);
- long startTime = System.nanoTime();
-
FullPageId fullId = new FullPageId(pageId, grpId);
Segment seg = segment(grpId, pageId);
@@ -641,7 +639,6 @@ public class PersistentPageMemory implements PageMemory {
if (waitUntilPageIsFullyInitialized) {
waitUntilPageIsFullyInitialized(resPointer);
- metrics.recordPageAcquireTime(System.nanoTime() - startTime);
}
}
@@ -783,8 +780,6 @@ public class PersistentPageMemory implements PageMemory {
headerIsValid(lockedPageAbsPtr, true);
}
}
-
- metrics.recordPageAcquireTime(System.nanoTime() - startTime);
}
}
diff --git
a/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemoryMetricSource.java
b/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemoryMetricSource.java
index d467ba7f698..e4eb60ac0fb 100644
---
a/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemoryMetricSource.java
+++
b/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemoryMetricSource.java
@@ -35,7 +35,6 @@ public class PersistentPageMemoryMetricSource implements
MetricSource {
public static final String PAGE_CACHE_HITS = "PageCacheHits";
public static final String DIRTY_PAGES = "DirtyPages";
public static final String LOADED_PAGES = "LoadedPages";
- public static final String PAGE_ACQUIRE_TIME = "PageAcquireTime";
private final String name;
diff --git
a/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemoryMetrics.java
b/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemoryMetrics.java
index 04159c19a2f..2dab355d5cf 100644
---
a/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemoryMetrics.java
+++
b/modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemoryMetrics.java
@@ -21,12 +21,10 @@ import static
org.apache.ignite.internal.pagememory.persistence.PersistentPageMe
import static
org.apache.ignite.internal.pagememory.persistence.PersistentPageMemoryMetricSource.LOADED_PAGES;
import static
org.apache.ignite.internal.pagememory.persistence.PersistentPageMemoryMetricSource.PAGES_READ;
import static
org.apache.ignite.internal.pagememory.persistence.PersistentPageMemoryMetricSource.PAGES_WRITTEN;
-import static
org.apache.ignite.internal.pagememory.persistence.PersistentPageMemoryMetricSource.PAGE_ACQUIRE_TIME;
import static
org.apache.ignite.internal.pagememory.persistence.PersistentPageMemoryMetricSource.PAGE_CACHE_HITS;
import static
org.apache.ignite.internal.pagememory.persistence.PersistentPageMemoryMetricSource.PAGE_CACHE_MISSES;
import static
org.apache.ignite.internal.pagememory.persistence.PersistentPageMemoryMetricSource.PAGE_REPLACEMENTS;
-import org.apache.ignite.internal.metrics.DistributionMetric;
import org.apache.ignite.internal.metrics.IntGauge;
import org.apache.ignite.internal.metrics.LongAdderMetric;
import org.apache.ignite.internal.metrics.LongGauge;
@@ -34,13 +32,6 @@ import
org.apache.ignite.internal.pagememory.configuration.PersistentDataRegionC
/** Persistent page memory metrics. */
public class PersistentPageMemoryMetrics implements PageCacheMetrics {
- private static final long[] PAGE_ACQUISITIONS_BOUNDS_NANOS = {
- 1_000, // 1µs - cache hit
- 100_000, // 100µs - page cache miss, fast SSD
- 10_000_000, // 10ms - HDD or slow I/O
- 100_000_000 // 100ms - very slow I/O or high load
- };
-
private final LongAdderMetric readPagesFromDisk;
private final LongAdderMetric writePagesToDisk;
@@ -49,8 +40,6 @@ public class PersistentPageMemoryMetrics implements
PageCacheMetrics {
private final LongAdderMetric pageCacheMisses;
- private final DistributionMetric pageAcquireTime;
-
private final LongAdderMetric pageReplacements;
PersistentPageMemoryMetrics(
@@ -97,12 +86,6 @@ public class PersistentPageMemoryMetrics implements
PageCacheMetrics {
"Number of times a page was not found in the page cache and
had to be loaded from disk."
));
- pageAcquireTime = source.addMetric(new DistributionMetric(
- PAGE_ACQUIRE_TIME,
- "Distribution of page acquisition time in nanoseconds.",
- PAGE_ACQUISITIONS_BOUNDS_NANOS
- ));
-
pageReplacements = source.addMetric(new LongAdderMetric(
PAGE_REPLACEMENTS,
"Number of times a page was replaced (evicted) from the page
cache."
@@ -143,11 +126,6 @@ public class PersistentPageMemoryMetrics implements
PageCacheMetrics {
pageCacheMisses.increment();
}
- /** Records a page acquisition time in nanoseconds. */
- public void recordPageAcquireTime(long nanos) {
- pageAcquireTime.add(nanos);
- }
-
/** Increases the page replacement metric by one. */
@Override
public void incrementPageReplacement() {
