This is an automated email from the ASF dual-hosted git repository.
tarmstrong pushed a commit to branch 2.x
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 08d634ffb62609175d7113efbf7d0352672adf13
Author: Tim Armstrong <tarmstr...@cloudera.com>
AuthorDate: Fri Jun 15 11:32:07 2018 -0700
IMPALA-7179: allow_multiple_scratch_dirs_per_device=true by default
The previous default was often confusing to users of Impala. It is
simpler to do exactly what is asked instead of trying to fix bad
configurations automatically.
Testing:
Ran core tests.
Change-Id: I23394c9949ae4cd0a21d7bb25551371b3198e76c
Reviewed-on: http://gerrit.cloudera.org:8080/10736
Reviewed-by: anujphadke <apha...@cloudera.com>
Reviewed-by: Dan Hecht <dhe...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
---
be/src/runtime/tmp-file-mgr.cc | 2 +-
tests/custom_cluster/test_scratch_disk.py | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/be/src/runtime/tmp-file-mgr.cc b/be/src/runtime/tmp-file-mgr.cc
index a16775a..d6d5a51 100644
--- a/be/src/runtime/tmp-file-mgr.cc
+++ b/be/src/runtime/tmp-file-mgr.cc
@@ -42,7 +42,7 @@ DEFINE_bool(disk_spill_encryption, true,
"Set this to encrypt and perform an integrity "
"check on all data spilled to disk during a query");
DEFINE_string(scratch_dirs, "/tmp", "Writable scratch directories");
-DEFINE_bool(allow_multiple_scratch_dirs_per_device, false,
+DEFINE_bool(allow_multiple_scratch_dirs_per_device, true,
"If false and --scratch_dirs contains multiple directories on the same
device, "
"then only the first writable directory is used");
diff --git a/tests/custom_cluster/test_scratch_disk.py
b/tests/custom_cluster/test_scratch_disk.py
index 65bde66..c50ba24 100644
--- a/tests/custom_cluster/test_scratch_disk.py
+++ b/tests/custom_cluster/test_scratch_disk.py
@@ -82,7 +82,8 @@ class TestScratchDir(CustomClusterTestSuite):
scratch because all directories are on same disk."""
normal_dirs = self.generate_dirs(5)
self._start_impala_cluster([
- '--impalad_args="-logbuflevel=-1
-scratch_dirs={0}"'.format(','.join(normal_dirs))])
+ '--impalad_args="-logbuflevel=-1
-scratch_dirs={0}"'.format(','.join(normal_dirs)),
+ '--impalad_args=--allow_multiple_scratch_dirs_per_device=false'])
self.assert_impalad_log_contains("INFO", "Using scratch directory ",
expected_count=1)
exec_option = vector.get_value('exec_option')
