This is an automated email from the ASF dual-hosted git repository.
boroknagyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 1d4a6bc47fc53ae9cc50c3793e84e7ba85a43bf2
Author: jasonmfehr <jf...@cloudera.com>
AuthorDate: Thu Feb 29 12:42:31 2024 -0800
IMPALA-12859: Ensure query log estimated memory is initialized
The query_log_est_total_size_ variable contains the total estimated
size in bytes of the query log list that holds the most recent queries
for use by the Impala http server in the web UI and web API. This
variable was not explicitly initialized and thus would sometimes be
initialized to very large values (on the order of petabytes). Since
this variable is read before being set, the large value prevented any
queries from being placed into the query log since those code saw the
query log as taking too much memory.
The internal-server-test calls the Impala web API to assert that
queries are run successfully. Since no queries were being placed into
the query log, no queries were being returned via the web API. The
internal-server-test ctests were then failing because they could not
assert their queries since the queries could not be found.
Change-Id: I431b50d35fb2db848cfd9cbc1ba32c4aa83931d2
Reviewed-on: http://gerrit.cloudera.org:8080/21094
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
---
be/src/service/impala-server.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/be/src/service/impala-server.h b/be/src/service/impala-server.h
index 4cd5dd5d5..c456d803b 100644
--- a/be/src/service/impala-server.h
+++ b/be/src/service/impala-server.h
@@ -1155,7 +1155,7 @@ class ImpalaServer : public ImpalaServiceIf,
/// Estimated individual and total size of records in query_log_ in bytes.
std::list<int64_t> query_log_est_sizes_;
- int64_t query_log_est_total_size_;
+ int64_t query_log_est_total_size_ = 0;
/// Sets the given query_record (and retried_query_record too if given) for
the given
/// query_id. Returns an error Status if the given query_id cannot be found
in the
