This is an automated email from the ASF dual-hosted git repository. boroknagyz pushed a commit to branch branch-4.4.0 in repository https://gitbox.apache.org/repos/asf/impala.git
commit af31854a265e54111e6caf870ca28753038d5bde Author: Riza Suminto <riza.sumi...@cloudera.com> AuthorDate: Mon Apr 15 16:13:15 2024 -0700 IMPALA-13016: Fix ambiguous row_regex that check for no-existence There are few row_regex patterns used in EE test files that are ambiguous on whether a pattern does not exist in all parts of the results/runtime profile or at least one row does not have that pattern. These were caught by grepping the following pattern: $ git grep -n "row_regex: (?\!" This patch replaces them with either with !row_regex or VERIFY_IS_NOT_IN comment. Testing: - Run and pass modified tests. Change-Id: Ic81de34bf997dfaf1c199b1fe1b05346b55ff4da Reviewed-on: http://gerrit.cloudera.org:8080/21333 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- .../functional-query/queries/QueryTest/acid-clear-statsaccurate.test | 4 ++-- .../workloads/functional-query/queries/QueryTest/acid-truncate.test | 4 ++-- .../functional-query/queries/QueryTest/clear-statsaccurate.test | 4 ++-- .../functional-query/queries/QueryTest/iceberg-v2-directed-mode.test | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/testdata/workloads/functional-query/queries/QueryTest/acid-clear-statsaccurate.test b/testdata/workloads/functional-query/queries/QueryTest/acid-clear-statsaccurate.test index 09ea3f216..beaeb4070 100644 --- a/testdata/workloads/functional-query/queries/QueryTest/acid-clear-statsaccurate.test +++ b/testdata/workloads/functional-query/queries/QueryTest/acid-clear-statsaccurate.test @@ -30,8 +30,8 @@ row_regex: .*COLUMN_STATS_ACCURATE.* invalidate metadata insertonly_nopart_colstatschg; insert into insertonly_nopart_colstatschg values (2); show create table insertonly_nopart_colstatschg; ----- RESULTS -row_regex: (?!.*COLUMN_STATS_ACCURATE) +---- RESULTS: VERIFY_IS_NOT_IN +row_regex: .*COLUMN_STATS_ACCURATE.* ==== ---- QUERY select x from insertonly_nopart_colstatschg; diff --git a/testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test b/testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test index b50c09812..bed749312 100644 --- a/testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test +++ b/testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test @@ -43,8 +43,8 @@ STRING,STRING,STRING,STRING ==== ---- QUERY show create table tt; ----- RESULTS -row_regex: (?!.*COLUMN_STATS_ACCURATE) +---- RESULTS: VERIFY_IS_NOT_IN +row_regex: .*COLUMN_STATS_ACCURATE.* ==== ---- QUERY truncate table tt; diff --git a/testdata/workloads/functional-query/queries/QueryTest/clear-statsaccurate.test b/testdata/workloads/functional-query/queries/QueryTest/clear-statsaccurate.test index 7ccebb037..2de5486e3 100644 --- a/testdata/workloads/functional-query/queries/QueryTest/clear-statsaccurate.test +++ b/testdata/workloads/functional-query/queries/QueryTest/clear-statsaccurate.test @@ -24,8 +24,8 @@ row_regex: .*COLUMN_STATS_ACCURATE.* invalidate metadata ext_nopart_colstatschg; insert into ext_nopart_colstatschg values (2); show create table ext_nopart_colstatschg; ----- RESULTS -row_regex: (?!.*COLUMN_STATS_ACCURATE) +---- RESULTS: VERIFY_IS_NOT_IN +row_regex: .*COLUMN_STATS_ACCURATE.* ==== ---- QUERY select x from ext_nopart_colstatschg; diff --git a/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-directed-mode.test b/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-directed-mode.test index 67f0a2c1f..c582bebf9 100644 --- a/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-directed-mode.test +++ b/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-directed-mode.test @@ -11,7 +11,7 @@ select count(1) from iceberg_v2_partitioned_position_deletes; bigint ---- RUNTIME_PROFILE aggregation(SUM, BuildRows): 30 -row_regex: (?!.*F03:JOIN BUILD.*) +!row_regex: .*F03:JOIN BUILD.* ==== ---- QUERY # Same as above but here there is a separate fragment for the join build.