dockerzhang commented on a change in pull request #2168:
URL: https://github.com/apache/incubator-inlong/pull/2168#discussion_r785612383
##########
File path:
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/reader/SqlReader.java
##########
@@ -54,12 +55,12 @@
private static final String SQL_READER_TAG_NAME = "AgentSqlMetric";
- private static final String JOB_DATABASE_USER = "job.database.user";
- private static final String JOB_DATABASE_PASSWORD =
"job.database.password";
- private static final String JOB_DATABASE_HOSTNAME =
"job.database.hostname";
- private static final String JOB_DATABASE_PORT = "job.database.port";
+ private static final String JOB_DATABASE_USER = "job.user";
Review comment:
how about using configuration with `job.sql.` prefix？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
