baomingyu commented on a change in pull request #2724:
URL: https://github.com/apache/incubator-inlong/pull/2724#discussion_r814679922



##########
File path: 
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AbstractService.java
##########
@@ -102,7 +102,9 @@ public  void run() {
                         }
                         count++;
                     }
-                    batchInsertEntities(entryList);
+                    if (entryList.size() > 0) {

Review comment:
       CollectionUtils.isNotEmpty  need check more than once.
   like this :
   coll == null || coll.isEmpty();
    and here entryList is never be null. so check entryList.size()  will be 
beset.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to