gong commented on a change in pull request #3036:
URL: https://github.com/apache/incubator-inlong/pull/3036#discussion_r823310918
##########
File path:
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/util/InlongStreamSinkTransfer.java
##########
@@ -244,21 +230,32 @@ private static HiveSinkRequest
createHiveRequest(StreamSink streamSink, InlongSt
hiveSinkRequest.setPrimaryPartition(hiveSink.getPrimaryPartition());
hiveSinkRequest.setSecondaryPartition(hiveSink.getSecondaryPartition());
if (CollectionUtils.isNotEmpty(hiveSink.getStreamFields())) {
- List<SinkFieldRequest> fieldRequests = hiveSink.getStreamFields()
- .stream()
- .map(streamField -> {
- SinkFieldRequest storageFieldRequest = new
SinkFieldRequest();
-
storageFieldRequest.setFieldName(streamField.getFieldName());
-
storageFieldRequest.setFieldType(streamField.getFieldType().toString());
-
storageFieldRequest.setFieldComment(streamField.getFieldComment());
- return storageFieldRequest;
- })
- .collect(Collectors.toList());
+ List<SinkFieldRequest> fieldRequests =
createSinkFields(streamSink.getStreamFields(),
+ streamInfo.getFieldList());
hiveSinkRequest.setFieldList(fieldRequests);
}
return hiveSinkRequest;
}
+ private static List<SinkFieldRequest> createSinkFields(List<StreamField>
sinkFields,
+ List<InlongStreamFieldInfo> sourceFields) {
+ List<SinkFieldRequest> sinkFieldRequests = Lists.newArrayList();
+ for (int i = 0; i < sinkFields.size(); i++) {
+ SinkFieldRequest sinkFieldRequest = new SinkFieldRequest();
+ StreamField sinkField = sinkFields.get(i);
+ sinkFieldRequest.setFieldName(sinkField.getFieldName());
+ sinkFieldRequest.setFieldType(sinkField.getFieldType().toString());
+ sinkFieldRequest.setFieldComment(sinkField.getFieldComment());
+ if (sourceFields.size() > i && sourceFields.get(i) != null) {
+ InlongStreamFieldInfo sourceField = sourceFields.get(i);
+
sinkFieldRequest.setSourceFieldName(sourceField.getFieldName());
+
sinkFieldRequest.setSourceFieldType(sourceField.getFieldType());
+ }
+ sinkFieldRequests.add(sinkFieldRequest);
+ }
+ return sinkFieldRequests;
+ }
+
Review comment:
Is field mapping created by order of sink field list and stream field
list ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
