baomingyu commented on a change in pull request #3235:
URL: https://github.com/apache/incubator-inlong/pull/3235#discussion_r830444431
##########
File path:
inlong-manager/manager-test/src/main/resources/sql/apache_inlong_manager.sql
##########
@@ -151,7 +151,7 @@ CREATE TABLE `third_party_cluster`
`id` int(11) NOT NULL AUTO_INCREMENT COMMENT 'Incremental
primary key',
`name` varchar(128) NOT NULL COMMENT 'Cluster name',
`type` varchar(32) NOT NULL COMMENT 'Cluster type, including TUBE,
PULSAR, etc.',
- `ip` varchar(64) NOT NULL COMMENT 'Cluster IP',
+ `ip` text NOT NULL COMMENT 'Cluster IP',
Review comment:
please, change this line comment, and give one example.
##########
File path:
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/ThirdPartyClusterServiceImpl.java
##########
@@ -177,28 +177,59 @@ public Boolean delete(Integer id, String operator) {
}
@Override
- public List<DataProxyResponse> getIpList(DataProxyRequest request) {
- LOGGER.debug("begin to list data proxy by request={}", request);
- List<ThirdPartyClusterEntity> entityList =
thirdPartyClusterMapper.selectByType(Constant.CLUSTER_DATA_PROXY);
- if (entityList == null || entityList.isEmpty()) {
- LOGGER.warn("success to list data proxy, but not found anything
for request={}", request);
+ public List<DataProxyResponse> getIpList(String clusterName) {
+ LOGGER.debug("begin to list data proxy by clusterName={}",
clusterName);
+ ThirdPartyClusterEntity entity =
thirdPartyClusterMapper.selectByName(clusterName);
Review comment:
this change need client must provide clusterName as parameter ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
