[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4666: [INLONG-4665][Sort] The primary key must be _id in mongoDB CDC Connector

Wed, 15 Jun 2022 04:49:30 -0700 


healchow commented on code in PR #4666:
URL: https://github.com/apache/incubator-inlong/pull/4666#discussion_r897882084


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/ExtractNodeUtils.java:
##########
@@ -385,7 +385,6 @@ public static MongoExtractNode 
createExtractNode(MongoDBSource source) {
                 fieldInfos,
                 null,
                 properties,
-                source.getPrimaryKey(),

Review Comment:
   If the primary key cannot be changed, can we remove this field in the 
manager module?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to