healchow commented on code in PR #5079:
URL: https://github.com/apache/inlong/pull/5079#discussion_r922930847
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/enums/KafkaScanStartupMode.java:
##########
@@ -25,7 +25,8 @@
*/
public enum KafkaScanStartupMode {
EARLIEST_OFFSET("earliest-offset"),
- LATEST_OFFSET("latest-offset");
+ LATEST_OFFSET("latest-offset"),
+ SPECIFIC_OFFSET("specific-offsets");
Review Comment:
Maybe calling it `SPECIFIC_OFFSETS` is more explicit.
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/source/kafka/KafkaSource.java:
##########
@@ -58,11 +58,12 @@ public class KafkaSource extends StreamSource {
private String byteSpeedLimit;
@ApiModelProperty(value = "Topic partition offset",
- notes = "For example, '0#100_1#10' means the offset of partition 0
is 100, the offset of partition 1 is 10")
- private String topicPartitionOffset;
+ notes = "For
example,'partition:0,offset:42;partition:1,offset:300' "
+ + "indicates offset 42 for partition 0 and offset 300 for
partition 1.")
+ private String partitionOffset;
Review Comment:
Please change this param in `KafkaSourceDTO` and `KafkaSourceRequest` at the
same time.
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/constant/KafkaConstant.java:
##########
@@ -35,6 +35,8 @@ public class KafkaConstant {
public static final String KAFKA = "kafka";
+ public static final String SCAN_STARTUP_SPECIFIC_OFFSET =
"scan.startup.specific-offsets";
Review Comment:
Maybe calling it `SCAN_STARTUP_SPECIFIC_OFFSETS` is more explicit.
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/extract/KafkaExtractNode.java:
##########
@@ -75,6 +75,9 @@ public class KafkaExtractNode extends ExtractNode implements
Metadata, Serializa
@JsonProperty("groupId")
private String groupId;
+ @JsonProperty("kafkaScanSpecificOffset")
+ private String kafkaScanSpecificOffset;
Review Comment:
This is a Kafka extract node, so just calling it `scanSpecificOffset` is
enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
