healchow commented on code in PR #5118:
URL: https://github.com/apache/inlong/pull/5118#discussion_r924566063
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/cluster/InlongClusterService.java:
##########
@@ -29,13 +29,22 @@
import org.apache.inlong.manager.common.pojo.cluster.ClusterTagRequest;
import org.apache.inlong.manager.common.pojo.cluster.ClusterTagResponse;
import org.apache.inlong.manager.common.pojo.dataproxy.DataProxyNodeInfo;
+import org.apache.inlong.manager.dao.entity.UserEntity;
import java.util.List;
/**
* Inlong cluster service layer interface
*/
public interface InlongClusterService {
+
+ /**
+ * Get user info by user name
+ *
+ * @param username username
+ * @return user info
+ */
+ UserEntity getByName(String username);
Review Comment:
1. `getByUsername` is better.
2. This method should move to `UserService`, which is more object-oriented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
