vernedeng commented on code in PR #5389: URL: https://github.com/apache/inlong/pull/5389#discussion_r946452542
########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/kafka/KafkaResourceOperators.java: ########## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.manager.service.resource.queue.kafka; + +import javax.validation.constraints.NotBlank; +import javax.validation.constraints.NotNull; + +import lombok.extern.slf4j.Slf4j; +import org.apache.inlong.manager.common.consts.MQType; +import org.apache.inlong.manager.common.enums.ClusterType; +import org.apache.inlong.manager.common.exceptions.WorkflowListenerException; +import org.apache.inlong.manager.common.util.Preconditions; +import org.apache.inlong.manager.pojo.cluster.ClusterInfo; +import org.apache.inlong.manager.pojo.cluster.kafka.KafkaClusterInfo; +import org.apache.inlong.manager.pojo.group.InlongGroupInfo; +import org.apache.inlong.manager.pojo.stream.InlongStreamBriefInfo; +import org.apache.inlong.manager.pojo.stream.InlongStreamInfo; +import org.apache.inlong.manager.service.cluster.InlongClusterService; +import org.apache.inlong.manager.service.core.ConsumptionService; +import org.apache.inlong.manager.service.resource.queue.QueueResourceOperator; +import org.apache.inlong.manager.service.stream.InlongStreamService; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Service; + +import java.util.List; + +/** + * kafka for create kafka Topic and Subscription + */ +@Slf4j +@Service +public class KafkaResourceOperators implements QueueResourceOperator { + + @Autowired + private InlongClusterService clusterService; + @Autowired + private InlongStreamService streamService; + @Autowired + private KafkaOperator kafkaOperator; + @Autowired + private ConsumptionService consumptionService; + + @Override + public boolean accept(String mqType) { + return MQType.KAFKA.equals(mqType); + } + + @Override + public void createQueueForGroup(@NotNull InlongGroupInfo groupInfo, @NotBlank String operator) { + Preconditions.checkNotNull(groupInfo, "inlong group info cannot be null"); + Preconditions.checkNotNull(operator, "operator cannot be null"); Review Comment: no need to call **_checkNotNull_** since the annotation @NotNull @NotBlank have ensured the availability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
