Yizhou-Yang commented on PR #6655:
URL: https://github.com/apache/inlong/pull/6655#issuecomment-1329963101

   I think that logdirtysink and s3dirtysink should be refactored to somewhere 
other than sort-base because essentially they are two sink factories. two 
questions: 1) will inlong manager need to change to adapt to these changes? 2) 
when are these sinks created? in other sink's connectors? when manager parses 
the parameters? or when the task is created?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to