healchow commented on code in PR #7230:
URL: https://github.com/apache/inlong/pull/7230#discussion_r1068972588
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/StreamSinkServiceImpl.java:
##########
@@ -372,24 +372,53 @@ public List<? extends StreamSink>
listByCondition(SinkPageRequest request, UserI
@Transactional(rollbackFor = Throwable.class)
public Boolean update(SinkRequest request, String operator) {
LOGGER.info("begin to update sink by id: {}", request);
- this.checkParams(request);
- Preconditions.checkNotNull(request.getId(),
ErrorCodeEnum.ID_IS_EMPTY.getMessage());
-
- // Check if it can be modified
- String groupId = request.getInlongGroupId();
- String streamId = request.getInlongStreamId();
- String sinkName = request.getSinkName();
- groupCheckService.checkGroupStatus(groupId, operator);
-
+ if (request == null) {
+ throw new BusinessException(ErrorCodeEnum.INVALID_PARAMETER,
+ "inlong sink request is empty");
+ }
+ if (request.getId() == null) {
+ throw new BusinessException(ErrorCodeEnum.ID_IS_EMPTY);
+ }
+ StreamSinkEntity curEntity =
sinkMapper.selectByPrimaryKey(request.getId());
+ if (curEntity == null) {
+ throw new BusinessException(ErrorCodeEnum.SINK_INFO_NOT_FOUND);
+ }
+ // check record version
+ if (!Objects.equals(curEntity.getVersion(), request.getVersion())) {
Review Comment:
Finally, for the verification of fields that are not allowed to be modified,
please extract them into a special method for verifying parameters, which is
more object-oriented and also prevents too much code in a single method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
