gong commented on code in PR #7580:
URL: https://github.com/apache/inlong/pull/7580#discussion_r1156775850
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/internal/JdbcMultiBatchingOutputFormat.java:
##########
@@ -656,10 +656,8 @@ protected void attemptFlush() throws IOException {
} catch (Exception e) {
tableException = e;
LOG.warn("Flush all data for tableIdentifier:{} get err:",
tableIdentifier, e);
- if (dirtySinkHelper.getDirtySink() == null) {
- getAndSetPkFromErrMsg(tableIdentifier, e.getMessage());
- updateOneExecutor(true, tableIdentifier);
- }
+ getAndSetPkFromErrMsg(tableIdentifier, e.getMessage());
+ updateOneExecutor(true, tableIdentifier);
Review Comment:
getAndSetPkFromErrMsg pass param is error. It should be
getAndSetPkFromErrMsg(e.getMessage(), tableIdentifier); you need rebase master
when resove conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
