gong commented on code in PR #8141:
URL: https://github.com/apache/inlong/pull/8141#discussion_r1214163757
##########
inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/pom.xml:
##########
@@ -88,6 +88,12 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>sort-common</artifactId>
+ <version>1.8.0-SNAPSHOT</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
I suggest add relocation if you import this dependency.
like sort-connector-base
```
<relocation>
<pattern>org.apache.inlong.sort.base</pattern>
<shadedPattern>org.apache.inlong.sort.iceberg.shaded.org.apache.inlong.sort.base</shadedPattern>
</relocation>
```
Because some not changed connector won't be effected when modify sort-common
and connector also dependency sort-common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
