healchow commented on code in PR #8344:
URL: https://github.com/apache/inlong/pull/8344#discussion_r1244590549
##########
inlong-dashboard/src/plugins/sinks/defaults/MySQL.ts:
##########
@@ -47,7 +47,7 @@ const fieldTypesConf = {
TIME: () => '',
DATETIME: () => '',
CHAR: (m, d) => (1 <= m && m <= 255 ? '' : '1<=M<=255'),
- VARCHAR: (m, d) => (1 <= m && m <= 255 ? '' : '1<=M<=255'),
+ VARCHAR: (m, d) => (1 <= m && m <= 16383 ? '' : '1<=M<=16383'),
Review Comment:
Excuse me, how do you get the result of 16383 here?
If you consider the utf8mb4 character set, it takes up to 4 bytes to
represent 1 character, so 65535 / 4 = 16383, then the maximum length of the
char above is 255, which is also inaccurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
