doleyzi commented on code in PR #9905:
URL: https://github.com/apache/inlong/pull/9905#discussion_r1544312285
##########
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/AuditReporterImpl.java:
##########
@@ -198,50 +222,201 @@ public void add(int auditID, String auditTag, String
inlongGroupID, String inlon
keyJoiner.add(String.valueOf(auditID));
keyJoiner.add(auditTag);
keyJoiner.add(String.valueOf(auditVersion));
- addByKey(keyJoiner.toString(), count, size, delayTime);
+ addByKey(DEFAULT_ISOLATE_KEY, keyJoiner.toString(), count, size,
delayTime);
+ }
+
+ public void add(AuditDimensions dimensions, AuditValues values) {
+ StringJoiner keyJoiner = new StringJoiner(FIELD_SEPARATORS);
+ keyJoiner.add(String.valueOf(dimensions.getLogTime() / PERIOD));
+ keyJoiner.add(dimensions.getInlongGroupID());
+ keyJoiner.add(dimensions.getInlongStreamID());
+ keyJoiner.add(String.valueOf(dimensions.getAuditID()));
+ keyJoiner.add(dimensions.getAuditTag());
+ keyJoiner.add(String.valueOf(dimensions.getAuditVersion()));
+ addByKey(dimensions.getIsolateKey(), keyJoiner.toString(),
values.getCount(),
+ values.getSize(), values.getDelayTime());
}
/**
* Add audit info by key.
*/
- private void addByKey(String key, long count, long size, long delayTime) {
- if (countMap.get(key) == null) {
- countMap.put(key, new StatInfo(0L, 0L, 0L));
+ private void addByKey(long isolateKey, String statKey, long count, long
size, long delayTime) {
+ if (null == this.preStatMap.get(isolateKey)) {
+ this.preStatMap.putIfAbsent(isolateKey, new ConcurrentHashMap<>());
Review Comment:
The addKey function is a high-end function and will be called frequently,
but put is a low-frequency operation. Therefore, using get, the performance
consumption is less than putIfAbsent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
