fuweng11 commented on code in PR #9868: URL: https://github.com/apache/inlong/pull/9868#discussion_r1575895133
########## inlong-common/src/main/java/org/apache/inlong/common/pojo/sortstandalone/SortConfigResponse.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.common.pojo.sortstandalone; + +import lombok.AllArgsConstructor; +import lombok.Builder; +import lombok.Data; +import lombok.NoArgsConstructor; + +@Data +@Builder +@NoArgsConstructor +@AllArgsConstructor +public class SortConfigResponse { + + public static final int SUCC = 0; + public static final int NOUPDATE = 1; + public static final int FAIL = -1; + public static final int REQ_PARAMS_ERROR = -101; Review Comment: Done. ########## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/SortServiceImpl.java: ########## @@ -117,4 +189,126 @@ public void acceptPlugin(Plugin plugin) { sortPoller = pollerPlugin.getSortPoller(); } } + + @Override + public SortConfigResponse getSortConfig(String clusterName, String md5) { + if (StringUtils.isBlank(clusterName)) { + String errMsg = "blank cluster name or task name, return nothing"; Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
